andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Only add / to uri if really needed.

Browse Source 
Motivation:

We not need to include the start index in the check. See https://github.com/netty/netty/pull/6924#discussion_r125263918

Modifications:

Change <= to <

Result:

More correct code.
This commit is contained in:
Norman Maurer 2017-07-10 14:42:01 +02:00
parent e6a399a778
commit f1e14d0cb2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java
View File

@ -56,11 +56,11 @@ public class HttpRequestEncoder extends HttpObjectEncoder<HttpRequest> {
// See https://github.com/netty/netty/issues/2732 // See https://github.com/netty/netty/issues/2732
int index = uri.indexOf(QUESTION_MARK, start); int index = uri.indexOf(QUESTION_MARK, start);
if (index == -1) { if (index == -1) {
if (uri.lastIndexOf(SLASH) <= start) { if (uri.lastIndexOf(SLASH) < start) {
needSlash = true; needSlash = true;
} }
} else { } else {
if (uri.lastIndexOf(SLASH, index) <= start) { if (uri.lastIndexOf(SLASH, index) < start) {
uriCharSequence = new StringBuilder(uri).insert(index, SLASH); uriCharSequence = new StringBuilder(uri).insert(index, SLASH);
} }
} }