andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

HttpResponseStatus reasonPhrase equals usage

Browse Source 
Motivation:
HttpResponseStatus.reasonPhrase returns an AsciiString, but was compared using equals to a String. Other usages of the reasonPhrase also use the toString() method when not necessary.

Modifications:
- Use the contentEquals method

Result:
Correct comparison, and no toString() when not needed.
This commit is contained in:
Scott Mitchell 2015-08-17 22:40:19 -07:00
parent de55fba82b
commit ff9ac4997d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java
View File

@ -455,7 +455,7 @@ public class HttpResponseStatus implements Comparable<HttpResponseStatus> {
int code = Integer.parseInt(status.substring(0, space)); int code = Integer.parseInt(status.substring(0, space));
String reasonPhrase = status.substring(space + 1); String reasonPhrase = status.substring(space + 1);
HttpResponseStatus responseStatus = valueOf(code); HttpResponseStatus responseStatus = valueOf(code);
if (responseStatus.reasonPhrase().toString().equals(reasonPhrase)) { if (responseStatus.reasonPhrase().contentEquals(reasonPhrase)) {
return responseStatus; return responseStatus;
} else { } else {
return new HttpResponseStatus(code, reasonPhrase); return new HttpResponseStatus(code, reasonPhrase);
@ -507,7 +507,7 @@ public class HttpResponseStatus implements Comparable<HttpResponseStatus> {
status = valueOf(code); status = valueOf(code);
if (codeEnd < string.length()) { if (codeEnd < string.length()) {
String actualReason = string.toString(codeEnd + 1, string.length()); String actualReason = string.toString(codeEnd + 1, string.length());
if (!status.reasonPhrase().equals(actualReason)) { if (!status.reasonPhrase().contentEquals(actualReason)) {
status = new HttpResponseStatus(code, actualReason); status = new HttpResponseStatus(code, actualReason);
} }
} }