Commit Graph

2183 Commits

Author SHA1 Message Date
Trustin Lee
21269fa073 SSLEngine.beginHandshake() can throw a RuntimeException. 2011-08-02 15:09:12 +09:00
Trustin Lee
dc0498d82b NETTY-408 ChunkedStream generates 1-byte chunks for wrapped input streams that does have sane implementation of available() method
* Updated JavaDoc so that users don't specify an InputStream with poor available() implementation.
2011-08-02 09:48:18 +09:00
Trustin Lee
73d1f3fe02 NETTY-384 Another deadlock in ChunkedWriteHandler
ChunkedWriteHandler.discard() do not issue write requests to trigger exceptionCaught events and to notify write futures anymore.  Instead, it triggers exceptionCaught events and notifies write futures by itself.  Therefore, no write lock is involved during discard(), avoiding the reported dead lock.

However, this is a temporary solution, and eventually Netty must introduce more robust event thread model.
2011-08-02 09:33:27 +09:00
Trustin Lee
d72b89db21 NETTY-422 Add getPipeline() to CodecEmbedder so that a user can modify the pipeline dynamically. 2011-08-02 08:47:56 +09:00
Trustin Lee
59a349031a NETTY-423 Add ChannelPipeline.getNames() 2011-08-02 08:43:10 +09:00
Trustin Lee
5c62d54c67 NETTY-420 HttpClientCodec doesn't handle HEAD requests with Transfer-Encoding: chunked responses
* Reverted back the workaround for servers that sends unnecessary zero-byte chunk in a HEAD response because it actually breaks the codec when the server that conforms to the RFC.
2011-08-02 08:34:56 +09:00
Trustin Lee
bdeed00bbb NETTY-419 ObjectEncoder/ObjectDecoder fails with NPE when deserializing the java.lang.Class instance of an interface type
* Fixed a bug where deserializing an interface class fails due to wrong lookup.
* Implemented class lookup caching
2011-08-02 08:22:02 +09:00
Trustin Lee
6f7d2f4e23 NETTY-417 client channel still open after close and wait
* Fixed a bug in SslHandler where a write attempt made after SSLEngine is closed result in unnotified future.  Fixed by respecting the case where SslEngineResult.Status == CLOSED
2011-08-02 07:47:36 +09:00
Trustin Lee
c6fa82729c NETTY-417 client channel still open after close and wait
* Fixed a race condition where NioSocketChannel's state variable is updated *after* its close future is notified
* Removed unnecessary use of ChannelFutureListeners in NioSocketChannel and AbstractChannel
2011-08-02 07:38:16 +09:00
Trustin Lee
e85996ea46 Fixed a bug where the future associated with the close request is not notified when the channel was closed already when SslHandler attempts to send a closure_notify.
This shouldn't be a problem to most applications because they usually do not specify their own future object for the close request.
2011-08-02 07:19:57 +09:00
Felix Trepanier
46c9a5f094 do not encode if empty content 2011-08-02 06:47:53 +09:00
Trustin Lee
5579a91e1d NETTY-415 ChannelFuture.setFailure() not called when exception thrown handling Channel.close()
* Made sure the ChannelFuture associated with a downstream event is marked as failure when an exception is raised before it reaches at ChannelSink.
2011-08-02 06:35:38 +09:00
Trustin Lee
95f3af0a02 NETTY-418 isCompleteFailure() and isCompleteSuccess() are both true at the same time
* Fixed incorrect isPartialSuccess(), isPartialFailure(), isCompleteFailure() implementation
2011-08-01 06:11:14 +09:00
Trustin Lee
acb1ac84e6 NETTY-425 ChannelBuffers.compare does not handle unsigned bytes correctly
* Fixed a bug where signed comparison is made where unsigned comparison is expected
2011-08-01 04:28:08 +09:00
Trustin Lee
dfd7b0d6c3 NETTY-426 Prevent a user from reusing an upstream MessageEvent to write
something

Modified the pipeline implementations so that it rejects the attempt to
send an UpstreamMessageEvent to downstream
2011-08-01 04:16:02 +09:00
Trustin Lee
4bf26c31e9 NETTY-410 NioWorker write deadlock
Applied the patch provided by Greg Dhuse.
2011-08-01 04:00:01 +09:00
Trustin Lee
b9ef785b5b NETTY-406 ProtobufEncoder should also support Message.Builder
* Added support for Message.Builder
2011-08-01 03:46:22 +09:00
Trustin Lee
e2655f3c38 NETTY-389 java.lang.ClassCastException: org.jboss.netty.channel.FileRegion cannot be cast to org.jboss.netty.buffer.ChannelBuffer
* Updated JavaDoc to let users know that not all transports support FileRegion
* Added FIXME for future improvement
2011-08-01 03:39:06 +09:00
Trustin Lee
2acd74db83 NETTY-410 NioWorker write deadlock
Applied the patch provided by Greg Dhuse.
2011-08-01 01:32:55 +09:00
Jamie Furness
8982838ab2 Small fix to the http tunnel to prevent null pointer is attempt is made to close channel twice 2011-07-29 13:27:18 +09:00
Trustin Lee
ccc155e96f Fixed code format 2011-07-29 13:10:38 +09:00
nibin
65fc361eec * Fixed the bug in CookieEncoder if there are no cookie's set while
calling encode(). Without the fix, it ended up in calling the
exception "java.lang.StringIndexOutOfBoundsException".
* Also added test case to verify the patch

Change-Id: Ib96425e07ab50be027ade7be0748cceb6438a586
2011-07-29 13:03:55 +09:00
Trustin Lee
0062cb743c Added FIXME 2011-06-29 12:30:47 +09:00
fredericBregier
45a7692f07 Fixed NETTY-397, NETTY-398, NETTY-399, NETTY-403 2011-06-09 14:34:05 +09:00
Trustin Lee
dd1ff8d9cc Handle chunked encoding properly for non-200 responses 2011-05-26 12:11:30 +09:00
Trustin Lee
15792da167 Tabs to spaces 2011-05-11 18:11:36 +09:00
Trustin Lee
9db6bba913 NETTY-295 HTTP header getters/setters for date headers
* Added get/setDateHeader() methods that works with custom date
headers
* Removed get/setDateInMilliseconds() methods because they can be
simply represented with a chained getTime() call
* Fixed the inconsistent behavior & contract of
HttpHeaders.getContentLength() which does not throw an exception when
the header is missing or ill-formatted unless a default value is
specified
* Added clearHeaders() and removeHeader() to HttpHeaders
* Tabs to spaces
2011-05-11 18:09:49 +09:00
Rogiel Sulzbach
94cff9d041 NETTY-295 - HTTP header getters and setters for date headers
* Merged CookieDateFormat into HttpHeaderDateFormat, which can parse all
known date format variants related with HTTP
* Added HttpHeaders.get/setDate()
2011-05-11 17:02:11 +09:00
Trustin Lee
fd7b5769f7 Made IdleStateHandler @Sharable and removed unnecessary lazy
initialization in ReadTimeoutHandler
2011-05-04 17:30:09 +09:00
Trustin Lee
f22a55d6e2 NETTY-401 - NullPointerException when ReadTimeoutHandler is
concurrently initialized and destroyed

* Made ReadTimeoutHandler @Sharable
* Updated the UptimeClient again
** no static fields for global state - just reuse the handlers.
2011-05-04 17:12:11 +09:00
Trustin Lee
45a4b5b7c4 Fixed a bug in the uptime example where uptime is reset even when it
shouldn't be.
2011-05-04 16:53:57 +09:00
Bruce Mitchener
aca290096b Close bold tag. 2011-05-04 14:04:34 +09:00
Trustin Lee
e1869db913 Fixed various compiler warnings
* Missing @Override annotations
* Indirect access to a private member from inner classes
* Incorrect @see javadoc tags (should not use the @link tag)
* ..
2011-05-03 11:05:06 +09:00
Trustin Lee
a722f64991 Fixed indentation 2011-04-18 17:50:29 +09:00
iainmcgin
39a6baf380 fixing formatting for NioSocketChannelConfig, which I had incorrectly merged earlier. 2011-04-18 17:47:28 +09:00
iainmcgin
a617bd3290 Fixed formatting to conform to project standards 2011-04-18 17:47:12 +09:00
iainmcgin
f7729bc8bb Moved http tunnel implementation into org.jboss.netty.channel.socket.http package, replacing the original implementation.
Existing usage example has been deleted and should be replaced by an updated example using the new API.
2011-04-18 17:46:52 +09:00
iainmcgin
12d2c8ad2e NETTY-246: adding implementation to netty trunk for the 4.0.0 release. In order to get the tests to pass,
I had to change the surefire fork policy from "never" to "once", as it seems the classloader settings used
by the maven process were preventing jmock from mocking package private interfaces.
2011-04-18 17:44:54 +09:00
Trustin Lee
4aef19e947 Updated the initial Javadoc written by Veebs w/ a little formatting 2011-04-18 17:35:04 +09:00
Veebs
eb6ec29b14 Fixed SimpleDateFormat bug. Should use new SimpleDateFormat(HTTP_DATE_FORMAT, Locale.US), otherwise when running on for example Japanese OS, the resulting date would contains Japanese characters, and the browser would not be able to parse! 2011-04-18 17:23:46 +09:00
Veebs
a85249ced8 Added handing of HTTP headers with respect to browser caching and cache validation. 2011-04-18 17:23:13 +09:00
Will
e00e9bb8fa fix typo in exception message 2011-04-18 17:00:56 +09:00
Daniel Bevenius
98db0d3908 Added a timeout for the UdpClient so that the test cannot hang.
I noticed the build "hanging/halting" on the test when running the cobertura code coverage Eclipse plugin.
2011-04-18 16:57:03 +09:00
Trustin Lee
b26f13d3b9 Fixed compilation and removed unused fields 2011-04-04 18:21:47 +09:00
Trustin Lee
16750ffc28 NETTY-394 SslHandler does not work with a little endian buffer
Added SslHandler.getShort() which replaces ChannelBuffer.getShort() calls
2011-04-02 03:27:00 +09:00
Trustin Lee
6f7e2606a1 Merge branch 'master' of github.com:trustin/netty 2011-04-02 03:13:42 +09:00
Trustin Lee
94ac810f2e NETTY-393: SslHandler infinite loop on Apache Harmony with large payload
Increased the SSL buffer size by 1024 as advised
2011-04-02 03:08:24 +09:00
Trustin Lee
10e2fc44e5 Fixed NETTY-336 Fine-grained control over thread renaming
Fixed exception message
2011-03-29 16:15:11 +09:00
Trustin Lee
89de2e4b95 Fixed NETTY-336 Fine-grained control over thread renaming
NamedThreadFactory now can set the daemon flag and the thread priority
2011-03-29 16:12:55 +09:00
Trustin Lee
83bc3e794a Fixed NETTY-336 Fine-grained control over thread renaming
Added NamedThreadFactory so that a user can customize I/O thread names easily
2011-03-29 16:00:53 +09:00