Trustin Lee
8e2e22c270
Change the thread model slightly for new/freeInbound/OutboundBuffer() for future improvement
...
- Related: #1283
- Make ReplayingDecoder work with the modified thread model
2013-04-23 13:06:27 +09:00
Trustin Lee
c6f936f265
Ensure Javassist is loaded when running an example from an IDE
2013-04-23 13:03:25 +09:00
Trustin Lee
d85757a008
Fix memory leak in DefaultChannelHandlerContext
...
.. where freeInbound() and freeOutbound() are not called for all contexts
- Fixes #1298
2013-04-22 22:18:10 +09:00
Trustin Lee
e80fb65c36
Clean up the pipeline implementation / Ensure Embedded*Channel does not run pending tasks immediately
...
- Replace ugly 'prev != null' check with explicit event scheduling
- Fix an incorrect flag operation in freeHandlerBuffersAfterRemoval()
- Fix a bug in AbstractEmbeddedChannel.doRegister where it makes pending tasks immediately, where the pending tasks actually triggers inbound events
- Remove unnecessary suppression of inboundBufferUpdated() event in DefaultChannelPipeline, which potentially hides an event ordering bug. Unfortunately, I don't remember why I added it in cca35454d2
.
2013-04-22 19:41:00 +09:00
Norman Maurer
9c4bfa44d9
[ #1294 ] Make sure ByteBuf is released once written to channel
2013-04-22 11:04:56 +02:00
Norman Maurer
9a5f45a0c1
[ #1297 ] Make sure ResourceLeakDetector.open(...) is only used after constructing was successful
2013-04-22 10:07:22 +02:00
Trustin Lee
f979c17b67
Revert "Fix #1075 : DefaultChannelHandlerContext.fireChannelSuspended and fireInboundBufferUpdated do not work correctly if handlers with EventExecutor are added or removed from pipeline."
...
This reverts commit 273948055a
, which is
incorrect.
- Related: #1075
2013-04-22 16:59:43 +09:00
Norman Maurer
ab685de7a3
[ #1273 ] Fix resource leaks in test
2013-04-22 09:47:44 +02:00
Trustin Lee
c01d37ad05
Merge forwardBufferContent and setRemoved()
2013-04-22 14:47:17 +09:00
Norman Maurer
9b89c303cc
Return correct type on retain(..)
2013-04-21 13:41:34 +02:00
Norman Maurer
c987dd556e
[ #1295 ] Make sure retain(..) returns the correct WebSocketFrame type
2013-04-21 13:00:50 +02:00
Norman Maurer
2640832a38
Fix checkstyle
2013-04-21 12:52:42 +02:00
Trustin Lee
5846693577
Typo
2013-04-21 07:45:37 +09:00
Trustin Lee
475039532c
Split dynamic pipeline manipulation test into a new class / Replace PrefixThreadFactory with DefaultThreadFactory / Port the latest tests from the branch 'out-of-order' written by @normanmaurer
2013-04-21 07:44:37 +09:00
Norman Maurer
1cdb9e0b48
Just fail all futures that are left to not cause out-of-order writes
2013-04-19 07:06:22 +02:00
Norman Maurer
ca5554dfe7
[ #1236 ] Fix problem where adding a new ChannelHandler could block the eventloop
...
This change also introduce a few other changes which was needed:
* ChannelHandler.beforeAdd(...) and ChannelHandler.beforeRemove(...) were removed
* ChannelHandler.afterAdd(...) -> handlerAdded(...)
* ChannelHandler.afterRemoved(...) -> handlerRemoved(...)
* SslHandler.handshake() -> SslHandler.hanshakeFuture() as the handshake is triggered automatically after
the Channel becomes active
2013-04-19 07:00:50 +02:00
Trustin Lee
4a5dc32224
Fix a bug where LineBasedFrameDecoder does not handle too long lines correctly
...
- Related: #1287
2013-04-19 13:04:20 +09:00
Trustin Lee
6bb00cea6f
Fix failures in testsuite-osgi-deps
...
- Make only netty-common depend on javassist at compile scope, and
all others at test scope
2013-04-19 05:57:53 +09:00
Norman Maurer
58bfd6bf3b
[ #1284 ] Fix bug which can cause in infinity-loop triggered by a handler removal
2013-04-18 22:15:50 +02:00
Trustin Lee
18dca2a8a4
Fix checkstyle
2013-04-19 04:37:51 +09:00
Trustin Lee
8884e311f1
Fix a bug where DefaultCompositeByteBuf.nioBuffers() fails when its component's nioBufferCount() is greater than 1
...
- Fixes #1267
2013-04-19 04:35:44 +09:00
Trustin Lee
9e890f0ab8
Ensure to release the component when it's removed from CompositeByteBuf / Add tests for reference counting of CompositeByteBuf
2013-04-18 16:40:22 +09:00
Trustin Lee
70eee55a48
Revamp HttpContentEncoder
...
- Use state machine to simplify the code
- Always produce a chunked response for simplicity
- Change the signature of beginEncode() - HttpContent was simply unnecessary.
- Add more test cases
- Fixes #1280
2013-04-17 12:51:22 +09:00
Trustin Lee
4b1df148a6
Fix a bug where HttpContentEncoder does not update 'Content-Length' and 'Transfer-Encoding' correctly
...
- Add 'Content-Length' and remove 'Transfer-Encoding' in case of FullHttpMessage
- Remove 'Content-Length' and add 'Transfer-Encoding: chunked' in case of non-full HttpMessage
- Fixes #1275
2013-04-16 11:49:47 +09:00
Trustin Lee
7ee571968c
Use progress + total instead of delta
...
.. because there is sometimes a task whose total is only a rough
estimation
2013-04-15 20:11:02 +09:00
Trustin Lee
e69033a4c3
Replace TransferFuture(Listener) with (Channel)ProgressiveFuture(Listener)
...
- Now works without the transport package
- Renamed TransferFuture to ProgressiveFuture and ChannelProgressiveFuture / same for promises
- ProgressiveFutureListener now extends GenericProgressiveFutureListener and GenericFutureListener (add/removeTransferListener*() were removed)
- Renamed DefaultEventListeners to DefaultFutureListeners and only accept GenericFutureListeners
- Various clean-up
2013-04-15 15:26:20 +09:00
Trustin Lee
391c011764
Renames and typos
2013-04-15 11:03:59 +09:00
kerr
713b200adf
[ #1244 ] Support ChannelTransferPromise for sendFile
2013-04-14 21:22:03 +02:00
Norman Maurer
d8387fa4c3
[ #858 ] Merge ChannelPipeline.replaceAndForward into replace and removeAndForward into remove
2013-04-13 18:19:33 +02:00
Trustin Lee
4a792151b0
Rewrite bridge implementation in DefaultChannelHandlerContext
...
This commit splits bridge into two parts. One is NextBridgeFeeder,
which provides ByteBuf and MessageBuf that are local to the context
whose next*Buffer() has been invoked on. The other is a thread-safe
queue that stores the data fed by NextBridgeFeeder.feed().
By splitting the bridge into the two parts, the data pushed by a handler
is not lost anymore when the next handler who provided the next buffer
is removed from the pipeline.
- Fixes #1272
2013-04-12 17:38:04 +09:00
Trustin Lee
5bfb408b7d
Add setRefCnt(int) method to AbstractReferenceCounted(ByteBuf)
...
- Fixes #1265
2013-04-11 19:36:27 +09:00
Trustin Lee
2600f46fd7
Fix checkstyle
2013-04-11 17:54:20 +09:00
Trustin Lee
15ac4127e4
Remove @Ignore and add expected / Fix inspector warnings
2013-04-11 17:29:37 +09:00
Trustin Lee
e556232aeb
Rename HandshakeCompletionEvent to SslHandshakeCompletionEvent
2013-04-11 16:50:42 +09:00
Norman Maurer
b3429af1cc
[ #1260 ] Fire a HandshakeCompletationEvent once the SSL handshake completes
2013-04-11 06:47:43 +02:00
Norman Maurer
725156f082
[ #1242 ] Fix infinity-loop which was triggered when a write failed and AioSocketChannel was used
2013-04-10 15:39:58 +02:00
Norman Maurer
3b8673733e
[ #1262 ] Respect adjustment when using SlicedByteBuf.nioBuffers()
2013-04-10 14:19:03 +02:00
Norman Maurer
4746e74124
[ #1247 ] Add javadocs which tell the limitation of the type detection as there is nothing we can do about
2013-04-10 11:27:54 +02:00
Norman Maurer
73db1f886d
[ #1247 ] Add test which shows the problem with concrete classes that pass in the type based on a generic
2013-04-10 07:08:42 +02:00
Trustin Lee
e8ee6a2772
Better exception message when tickDuration is too big
...
- Related: #1246
- Fix misc inspector warnings
2013-04-10 13:44:05 +09:00
Trustin Lee
b58e6787ee
Fix typo
2013-04-10 10:41:23 +09:00
Norman Maurer
da174f4290
Add a warning about SingleThreadEventExecutor.pendingTasks() operation
2013-04-09 12:50:29 +02:00
Norman Maurer
0efebd5a82
Allow to get an Iterator over all of the EventExecutor an EventExecutorGroup contains. Beside this allow to get basic stats for the EventExecutor like pendingTasks and executorCount
2013-04-09 15:45:18 +09:00
Norman Maurer
067a2af700
Fix a few typos
2013-04-08 21:23:53 +02:00
Norman Maurer
60cfb547b4
Fix logging of android platform detection
2013-04-08 21:19:20 +02:00
irelandKen
9308625b2c
Update FullHttpMessage.java
...
I think FullHttpMessage = HttpMessage + LastHttpContent,
not that FullHttpMessage = FullHttpMessage + LastHttpContent
2013-04-08 21:12:19 +02:00
Norman Maurer
51de21f250
[ #1246 ] Correctly convert to nanos
2013-04-08 10:42:54 +02:00
Norman Maurer
d34daebeca
[ #1238 ] Correctly log the content of the MessageBuf and not depend on MessageBuf.toString()
...
Add an extra static method to BufUtil which will convert the content of any MessaBuf implementation to a String
2013-04-08 09:45:00 +02:00
Norman Maurer
2a162eb140
Rename method to better reflect usage
2013-04-08 08:06:46 +02:00
Norman Maurer
2508c76e97
[ #1246 ] Fix cpu-spinning regression in HashedWheelTimer
...
Also remove the usage of System.currentTimeMillis() completely here to make it more consistent and correct
2013-04-08 07:01:08 +02:00