Trustin Lee
506474f569
Overhaul pipeline implementation for clarity and memory efficiency
...
This pull request cleans up our pipeline implementation by moving most
inter-context traversal code to DefaultChannelHandlerContext.
Previously, outbound traversal was done in DefaultChannelPipeline while
inbound traversal was done in DefaultChannelHandlerContext.
Also, to address the memory inefficiency issue raised in #920 , all
runnables are lazily instantiated.
2013-01-16 00:38:14 +09:00
Trustin Lee
337f5bbb8e
Automatic diagnosis of resource leaks
...
Now that we are going to use buffer pooling by default, it is obvious
that a user will forget to call .free() and report memory leak. In this
case, we should have a tool to determine if it is a bug in our allocator
implementation or in the user's code.
This pull request adds a system property flag called
'io.netty.resourceLeakDetection'. If set, when a user forgets to call
.free(), the ResourceLeakDetector will detect it and log a message with
detailed stack trace to tell where the leaked buffer has been allocated.
Because obtaining stack trace is an expensive operation, I used sampling
technique. Allocation is recorded only for every 113th allocation. I
chose 113 because it's a prime number.
In production, a user might not want to enable this option due to
potential performance impact. If a user does not specify the
'-Dio.netty.resourceLeakDetection' option leak detection is disabled.
Even if the leak detection is enabled, the overhead should be less than
5% because only ~1% of allocations are monitored.
I also replaced SharedResourceMisuseDetector with ResourceLeakDetector.
2013-01-15 14:15:27 +09:00
Norman Maurer
201df99ee0
Rename from io.netty.transport.* to io.netty.channel.*
2013-01-14 21:34:58 +01:00
Jestan Nirojan
983a70805c
Moved sctp transport classes from io.netty.channel.socket.sctp to it's own subpackage io.netty.channel.sctp
2013-01-14 21:27:49 +01:00
Jeff Pinner
c20d875817
Merge pull request #934 from jpinner/fix_spdy_regression_master
...
SPDY: fix regression in SpdyFrameDecoder.decodeHeaderBlock()
2013-01-14 10:59:54 -08:00
Jeff Pinner
f75b6b142c
SPDY: fix regression in SpdyFrameDecoder.decodeHeaderBlock()
2013-01-14 10:58:03 -08:00
Trustin Lee
1354b4a1ac
SPDY: allow empty header values in SPDY/3
...
Ported from 3
2013-01-14 22:59:11 +09:00
Trustin Lee
57153079a5
Chrome requires the :version: header in SPDY_SESSION_PUSHED_SYN_STREAM frames otherwise it issues a HTTP_TRANSACTION_SPDY_SEND_REQUEST_HEADERS and a SPDY_STREAM_ERROR saying "HEADERS incomplete headers, but pending data frames."
...
Ported from 3
2013-01-14 22:37:05 +09:00
Trustin Lee
573a723dc2
Fix a bug where ChannelPIpeline.remove/replace() fails when its channel is not registered yet
2013-01-14 21:50:08 +09:00
Trustin Lee
e263769a55
Fix a bug where the buffers are freed too early when a handler is removed or replaced
2013-01-14 21:43:45 +09:00
Trustin Lee
a03bc6ea1d
Fix a bug where freeInbound/OutboundBuffer() is not called when a handler is removed from a pipeline.
2013-01-14 20:54:12 +09:00
Jestan Nirojan
49bf02ce09
[ #929 ] Implemented multi-homing opertions in SctpServerChannels and SCTP Javadocs cleanup
2013-01-13 20:52:02 +01:00
Norman Maurer
eb91a6d4e6
[ #924 ] [ #914 ] Fix high CPU usage which was caused because the OP_CONNECT flag was not cleared after the connect was complete
2013-01-11 19:42:21 +01:00
Trustin Lee
04bae9bceb
Use sun.misc.Unsafe to access a direct ByteBuffer
...
- Add PooledUnsafeDirectByteBuf, a variant of PooledDirectByteBuf, which
accesses its underlying direct ByteBuffer using sun.misc.Unsafe.
- To decouple Netty from sun.misc.*, sun.misc.Unsafe is accessed via
PlatformDependent.
- This change solely introduces about 8+% improvement in direct memory
access according to the tests conducted as described in #918
2013-01-11 16:25:12 +09:00
Norman Maurer
e564157381
Fix one checkstyle and one compile error caused by the last commit
2013-01-11 07:45:22 +01:00
Norman Maurer
75b2dd592a
Merge branch 'master' of github.com:netty/netty
2013-01-11 07:33:54 +01:00
Trustin Lee
64ae8b6a37
Replace and merge DetectionUtil and DirectByteBufUtil into PlatformDependent and PlatformDependent0
...
PlatformDependent delegates the operations requires sun.misc.* to PlatformDependent0 to avoid runtime errors due to missing sun.misc.* classes.
2013-01-11 14:03:27 +09:00
Trustin Lee
896bbb67b6
Use sun.misc.Unsafe to access a direct buffer if possible
2013-01-10 21:30:11 +01:00
Norman Maurer
5b5b39a606
[ #916 ] Only access Cleaner if it is really present to prevent errors on android
2013-01-10 20:03:54 +01:00
Trustin Lee
bfa3445bb3
Remove netty-metrics-yammer from example dependencies
...
.. because it pulls SLF4J as a runtime dependency
2013-01-11 00:38:36 +09:00
Trustin Lee
f7a076e0ea
Clean up netty-metrics-yammer pom.xml
2013-01-11 00:16:06 +09:00
Trustin Lee
366c6c86dc
Remove redundant dependency version
2013-01-11 00:14:21 +09:00
Trustin Lee
8975406b86
Ensure the outbound buffer is not freed on write completion
...
- Fixes #919
2013-01-10 21:05:51 +09:00
Norman Maurer
ec5ad7b22c
[ #921 ] Fix NPE which can be thrown on bad-timing when using WebSocketClientHandshaker07
2013-01-10 12:40:27 +01:00
Trustin Lee
5bd8b41a58
Use Number.reverseBytes() instead of custom impl
2013-01-10 18:47:21 +09:00
Trustin Lee
340da3e97b
Fix infinite recursion
2013-01-10 18:43:20 +09:00
Trustin Lee
753d0bfbae
Remove the memory option previously added to avoid OOME
...
We don't see OOME anymore
2013-01-10 16:25:41 +09:00
Trustin Lee
665d022e82
Use a heap buffer from the allocator because it doesn't seem to cause OOME anymore
2013-01-10 16:23:40 +09:00
Trustin Lee
3fe9a58f41
Fix checkstyle
2013-01-10 15:35:36 +09:00
Trustin Lee
eb337ff5a7
Fix various inspection warnings
2013-01-10 15:23:58 +09:00
Trustin Lee
3c9d912355
Use InetSocketAddress wherever possible / Tighten the return type of Channel.parent()
2013-01-10 14:17:54 +09:00
Trustin Lee
793a571465
Fix a runtime type cast exception when calling RxtxChannel.local/remoteAddress()
2013-01-10 14:01:17 +09:00
Trustin Lee
b5e6350bcb
Fix compiler warning
2013-01-10 13:55:15 +09:00
Trustin Lee
8cba765463
Indentation
2013-01-10 13:28:09 +09:00
Trustin Lee
4528c793ba
Fix naming issues in RxtxChannelConfig / Format cleanup
2013-01-10 13:24:36 +09:00
Trustin Lee
0c3732cad5
Fix invalid module name format
2013-01-10 13:14:36 +09:00
Luke Wood
c094abad7b
[ #561 ] [ #912 ] Add Rxtx transport
2013-01-09 21:32:51 +01:00
Trustin Lee
d5a7057c3f
Fix inconsistent module name
2013-01-09 23:37:10 +09:00
Trustin Lee
7755a82674
Revert mistakenly committed test change
2013-01-09 21:29:41 +09:00
Trustin Lee
137f29ba65
Do not read if a channel is inactive
2013-01-09 21:28:31 +09:00
Trustin Lee
46e364e7b7
Remove unnecessary parameters
2013-01-09 20:36:16 +09:00
Trustin Lee
b9352ded13
Fix a bug where prev/next context is not always set
2013-01-09 20:34:22 +09:00
Trustin Lee
8586d43b23
Fix DefaultChannelPipeline.toString() / Remove unnecessary conditions
2013-01-09 19:16:09 +09:00
Trustin Lee
b6fcf3acc4
Simplify DefaultChannelPipeline
2013-01-09 19:13:43 +09:00
Norman Maurer
b742dcc209
[ #902 ] Remove usage of generics for output of Encoder/Decoder to make them more flexible again
2013-01-09 07:13:31 +01:00
Trustin Lee
5d2e0688ab
Fix checkstyle
2013-01-09 15:12:25 +09:00
Trustin Lee
5c2be33cae
Delegate to the actual encoder/decoder if possible
2013-01-09 15:09:20 +09:00
Trustin Lee
102563ec8f
No need to override ByteToMessageCodec.decoder.discardInboundReadBytes()
2013-01-09 15:05:03 +09:00
Trustin Lee
ef692b0c38
Add missing decodeLast()
2013-01-09 14:58:44 +09:00
Trustin Lee
b58a8f0106
Add missing codec operations in ByteToMessageCodec
2013-01-09 14:56:07 +09:00
