Go to file
Norman Maurer f23e901c99 [#5028] Fix re-entrance issue with channelWritabilityChanged(...) and write(...)
Motivation:

When always triggered fireChannelWritabilityChanged() directly when the update the pending bytes in the ChannelOutboundBuffer was made from within the EventLoop. This is problematic as this can cause some re-entrance issue if the user has a custom ChannelOutboundHandler that does multiple writes from within the write(...) method and also has a handler that will intercept the channelWritabilityChanged event and trigger another write when the Channel is writable. This can also easily happen if the user just use a MessageToMessageEncoder subclass and triggers a write from channelWritabilityChanged().

Modification:

- Always invoke the fireChannelWritabilityChanged() later on the EventLoop.
- Only trigger the fireChannelWritabilityChanged() if the channel is still active.
- when write(...) is called from outside the EventLoop we only increase the pending bytes in the outbound buffer (so that Channel.isWritable() is updated directly) but not cause a fireChannelWritabilityChanged(). The fireChannelWritabilityChanged() is then triggered once the task is picked up by the EventLoop as usual.

Result:

No more re-entrance possible because of writes from within channelWritabilityChanged(...) method.
2016-12-05 10:24:19 +01:00
all Support compiling netty with Java9 2016-12-03 20:12:56 +01:00
buffer Correctly handle the case when no ResourceLeakTracker was created for derived pooled buffers. This was missed in c2f4daa739 2016-12-04 23:09:23 +01:00
codec Misc clean up 2016-11-22 15:17:05 -08:00
codec-dns Fix false-positives when using ResourceLeakDetector. 2016-12-04 09:01:39 +01:00
codec-haproxy [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
codec-http fix #6066 Support optional filename in HttpPostRequestEncoder 2016-12-01 06:54:51 +01:00
codec-http2 Misc clean up 2016-11-22 15:17:05 -08:00
codec-memcache Fix buffer leaks in tests 2016-12-03 20:11:25 +01:00
codec-mqtt [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
codec-redis Correct release buffers in RedisEncoderTest 2016-12-01 21:18:53 +01:00
codec-smtp [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
codec-socks Replace internal class usage to make it compile on java9. This was missed in f332a00. 2016-12-03 21:01:36 +01:00
codec-stomp Fix buffer leaks in tests 2016-12-03 20:11:25 +01:00
codec-xml [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
common Fix false-positives when using ResourceLeakDetector. 2016-12-04 09:01:39 +01:00
example [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
handler Fix false-positives when using ResourceLeakDetector. 2016-12-04 09:01:39 +01:00
handler-proxy Read if needed on ProxyHandler's handshake. Fixes #5933. 2016-10-30 08:27:03 +01:00
license added support for Protobuf codec nano runtime 2016-01-19 21:39:17 +01:00
microbench Clean up following #6016 2016-11-21 12:35:40 -08:00
resolver fix 5868 -fix DefaultHostsFileEntriesResolverTest to pass on windows 7 2016-11-21 21:52:56 +01:00
resolver-dns Not use InternalThreadLocalMap where access may be done from outside the EventLoop. 2016-11-10 14:37:16 +01:00
tarball [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
testsuite Eliminate usage of releaseLater(...) to reduce memory usage during tests 2016-11-18 09:34:11 +01:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
transport [#5028] Fix re-entrance issue with channelWritabilityChanged(...) and write(...) 2016-12-05 10:24:19 +01:00
transport-native-epoll Correctly mark EpollServerDomainSocketChannel.isActive() as true after bind is complete.] 2016-12-01 21:26:11 +01:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
transport-udt [maven-release-plugin] prepare for next development iteration 2016-10-14 13:20:41 +02:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Use shaded dependency on JCTools instead of copy and paste 2016-06-10 13:19:45 +02:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt added support for Protobuf codec nano runtime 2016-01-19 21:39:17 +01:00
README.md Updating Branches to look section to match the current branching structure of the project 2016-03-10 22:08:01 +01:00
pom.xml Support compiling netty with Java9 2016-12-03 20:12:56 +01:00
run-example.sh Add an example client for codec-redis 2016-04-23 11:18:12 -07:00

README.md

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.