andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Bug in Regular Expression in Makefile (#4682)

Browse Source 
Summary:
False-negative about path not existing. The regex is ignoring the "." in front of a path.
Example: "./path/to/file"
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4682

Differential Revision: D13777110

Pulled By: sagar0

fbshipit-source-id: 9f8173b7581407555fdc055580732aeab37d4ade
This commit is contained in:
Remington Brasga 2019-01-23 10:19:27 -08:00 committed by Facebook Github Bot
parent cbe0239270
commit 1eded07f00
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -198,7 +198,7 @@ include make_config.mk
CLEAN_FILES += make_config.mk CLEAN_FILES += make_config.mk
missing_make_config_paths := $(shell \ missing_make_config_paths := $(shell \
grep "\/\S*" -o $(CURDIR)/make_config.mk | \ grep "./\S*\|/\S*" -o $(CURDIR)/make_config.mk | \
while read path; \ while read path; \
do [ -e $$path ] || echo $$path; \ do [ -e $$path ] || echo $$path; \
done | sort | uniq) done | sort | uniq)