andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove an unused option (#4888)

Browse Source 
Summary:
Remove `garbage_collection_deletion_size_threshold` as it is not used anywhere.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4888

Differential Revision: D13685982

Pulled By: sagar0

fbshipit-source-id: e08d3017b9a0c8fa99bc332b595ee4ed9db70c87
This commit is contained in:
Sagar Vemuri 2019-01-16 11:23:42 -08:00 committed by Facebook Github Bot
parent 128f532858
commit 3cfc7515fc
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
utilities/blob_db/blob_db.cc
View File

@ -96,9 +96,6 @@ void BlobDBOptions::Dump(Logger* log) const {
ROCKS_LOG_HEADER( ROCKS_LOG_HEADER(
log, " BlobDBOptions.garbage_collection_interval_secs: %" PRIu64, log, " BlobDBOptions.garbage_collection_interval_secs: %" PRIu64,
garbage_collection_interval_secs); garbage_collection_interval_secs);
ROCKS_LOG_HEADER(
log, "BlobDBOptions.garbage_collection_deletion_size_threshold: %lf",
garbage_collection_deletion_size_threshold);
ROCKS_LOG_HEADER( ROCKS_LOG_HEADER(
log, " BlobDBOptions.disable_background_tasks: %d", log, " BlobDBOptions.disable_background_tasks: %d",
disable_background_tasks); disable_background_tasks);

4
utilities/blob_db/blob_db.h
View File

@ -76,10 +76,6 @@ struct BlobDBOptions {
// Time interval to trigger garbage collection, in seconds. // Time interval to trigger garbage collection, in seconds.
uint64_t garbage_collection_interval_secs = 60; uint64_t garbage_collection_interval_secs = 60;
// If garbage collection is enabled, blob files with deleted size no less
// than this ratio will become candidates to be cleanup.
double garbage_collection_deletion_size_threshold = 0.75;
// Disable all background job. Used for test only. // Disable all background job. Used for test only.
bool disable_background_tasks = false; bool disable_background_tasks = false;