andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve the comment for BYTES_READ in statistics.

Browse Source 
Summary:
BYTES_READ only count the number of logical bytes read from
the DB::Get() function.  It neither includes all logical bytes read
nor indicates IO read bytes.

This patch improves the comment for BYTES_READ.

Test Plan: Only change comment.

Reviewers: sdong, rven, anthony, kradhakrishnan, IslamAbdelRahman, igor

Reviewed By: igor

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D40599
This commit is contained in:
Yueh-Hsuan Chiang 2015-06-24 15:00:51 -07:00
parent 72cab88959
commit 48da7a9cad
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/rocksdb/statistics.h
View File

@ -74,8 +74,13 @@ enum Tickers : uint32_t {
NUMBER_KEYS_READ, NUMBER_KEYS_READ,
// Number keys updated, if inplace update is enabled // Number keys updated, if inplace update is enabled
NUMBER_KEYS_UPDATED, NUMBER_KEYS_UPDATED,
// Bytes written / read // The number of uncompressed bytes issued by DB::Put(), DB::Delete(),
// DB::Merge(), and DB::Write().
BYTES_WRITTEN, BYTES_WRITTEN,
// The number of uncompressed bytes read from DB::Get(). It could be
// either from memtables, cache, or table files.
// For the number of logical bytes read from DB::MultiGet(),
// please use NUMBER_MULTIGET_BYTES_READ.
BYTES_READ, BYTES_READ,
NO_FILE_CLOSES, NO_FILE_CLOSES,
NO_FILE_OPENS, NO_FILE_OPENS,