andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fixed wrong type for "allow_compaction" parameter

Browse Source 
Summary:
should be boolean, not uint64_t
MSVC complains about it during compilation with error `include\rocksdb\advanced_options.h(77): warning C4800: 'uint64_t': forcing value to bool 'true' or 'false' (performance warning)`
Closes https://github.com/facebook/rocksdb/pull/2487

Differential Revision: D5310685

Pulled By: siying

fbshipit-source-id: 719a33b3dba4f711aa72e3f229013c188015dc86
This commit is contained in:
jsteemann 2017-06-23 09:32:11 -07:00 committed by Facebook Github Bot
parent 71f5bcb730
commit 521724ba82
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/rocksdb/advanced_options.h
View File

@ -72,7 +72,7 @@ struct CompactionOptionsFIFO {
CompactionOptionsFIFO() : max_table_files_size(1 * 1024 * 1024 * 1024) {} CompactionOptionsFIFO() : max_table_files_size(1 * 1024 * 1024 * 1024) {}
CompactionOptionsFIFO(uint64_t _max_table_files_size, CompactionOptionsFIFO(uint64_t _max_table_files_size,
uint64_t _allow_compaction) bool _allow_compaction)
: max_table_files_size(_max_table_files_size), : max_table_files_size(_max_table_files_size),
allow_compaction(_allow_compaction) {} allow_compaction(_allow_compaction) {}
}; };