Yanqin Jin
0304352882
Fix a bug in key comparison when index type is kBinarySearchWithFirstKey ( #8062 )
...
Summary:
When timestamp is enabled, key comparison should take this into account.
In `BlockBasedTableReader::Get()`, `BlockBasedTableReader::MultiGet()`,
assume the target key is `key`, and the timestamp upper bound is `ts`.
The highest key in current block is (key, ts1), while the lowest key in next
block is (key, ts2).
If
```
ts1 > ts > ts2
```
then
```
(key, ts1) < (key, ts) < (key, ts2)
```
It can be shown that if `Compare()` is used, then we will mistakenly skip the next
block. Instead, we should use `CompareWithoutTimestamp()`.
The majority of this PR makes some existing tests in `db_with_timestamp_basic_test.cc`
parameterized so that different index types can be tested. A new unit test is
also added for more coverage.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8062
Test Plan: make check
Reviewed By: ltamasi
Differential Revision: D27057557
Pulled By: riversand963
fbshipit-source-id: c1062fa7c159ed600a1ad7e461531d52265021f1
2021-03-15 17:44:52 -07:00
..
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2021-03-15 15:03:27 -07:00
2020-12-04 21:29:38 -08:00
2020-12-04 21:29:38 -08:00
2021-03-15 04:34:11 -07:00
2020-11-12 18:44:34 -08:00
2021-03-09 20:44:23 -08:00
2021-02-19 14:09:54 -08:00
2021-01-15 16:56:41 -08:00
2021-03-15 04:34:11 -07:00
2021-03-09 02:21:25 -08:00
2020-12-22 23:45:58 -08:00
2020-10-01 19:14:14 -07:00
2020-12-22 14:53:43 -08:00
2020-10-28 23:22:27 -07:00
2020-05-12 18:23:33 -07:00
2021-02-22 22:09:22 -08:00
2021-02-06 22:34:30 -08:00
2021-01-06 10:49:32 -08:00
2020-12-09 21:21:16 -08:00
2021-02-06 22:34:30 -08:00
2021-01-06 14:15:02 -08:00
2021-03-14 20:25:42 -07:00
2021-01-25 22:09:11 -08:00
2021-01-09 09:44:34 -08:00
2020-09-10 22:35:25 -07:00
2021-03-02 09:48:00 -08:00
2021-01-19 13:47:48 -08:00
2020-06-15 10:47:02 -07:00
2020-08-17 18:42:25 -07:00
2021-01-06 14:15:02 -08:00
2020-12-04 21:29:38 -08:00
2020-12-22 23:45:58 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2021-03-12 12:31:29 -08:00
2021-01-29 12:18:58 -08:00
2021-01-25 22:09:11 -08:00
2020-12-09 21:21:16 -08:00
2021-01-29 12:18:58 -08:00
2020-12-08 15:55:04 -08:00
2020-12-08 15:55:04 -08:00
2021-02-19 10:29:02 -08:00
2020-10-27 10:33:09 -07:00
2020-12-22 15:09:39 -08:00
2021-03-15 15:03:27 -07:00
2021-01-11 15:01:52 -08:00
2020-12-22 23:45:58 -08:00
2020-12-22 23:45:58 -08:00
2021-01-06 14:15:02 -08:00
2021-03-08 14:47:56 -08:00
2021-03-09 12:42:53 -08:00
2021-01-25 22:09:11 -08:00
2021-03-12 16:44:35 -08:00
2021-02-06 22:34:30 -08:00
2021-03-02 09:48:00 -08:00
2021-03-15 17:44:52 -07:00
2020-08-17 18:42:25 -07:00
2020-12-22 15:09:39 -08:00
2020-10-28 23:22:27 -07:00
2020-12-02 13:00:53 -08:00
2021-03-10 11:15:46 -08:00
2020-12-22 15:09:39 -08:00
2021-02-15 09:45:23 -08:00
2021-03-15 04:34:11 -07:00
2020-12-07 20:11:35 -08:00
2021-01-06 14:15:02 -08:00
2020-08-25 10:46:11 -07:00
2020-02-20 12:09:57 -08:00
2020-12-09 21:21:16 -08:00
2021-01-25 22:09:11 -08:00
2021-03-15 04:34:11 -07:00
2020-12-22 15:09:39 -08:00
2020-12-22 23:45:58 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-10-28 23:22:27 -07:00
2021-02-23 14:35:06 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2021-03-09 20:53:33 -08:00
2020-04-15 17:40:44 -07:00
2021-01-25 22:09:11 -08:00
2021-03-15 04:34:11 -07:00
2020-12-23 16:55:53 -08:00
2021-03-04 00:43:48 -08:00
2021-03-15 04:34:11 -07:00
2020-05-04 15:08:13 -07:00
2021-01-29 12:18:58 -08:00
2020-12-22 23:45:58 -08:00
2020-02-20 12:09:57 -08:00
2020-11-30 18:11:38 -08:00
2020-08-26 10:39:20 -07:00
2021-01-04 16:01:01 -08:00
2020-12-23 16:55:53 -08:00
2020-03-27 16:04:43 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-12-22 23:45:58 -08:00
2021-02-06 22:34:30 -08:00
2020-12-14 13:48:22 -08:00
2020-12-14 13:48:22 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-02-20 12:09:57 -08:00
2021-01-21 13:13:02 -08:00
2021-03-12 16:44:35 -08:00
2020-12-23 16:55:53 -08:00
2020-11-10 23:42:13 -08:00
2020-11-10 23:42:13 -08:00
2021-03-15 04:34:11 -07:00
2021-01-25 22:09:11 -08:00
2021-03-15 04:34:11 -07:00
2021-01-25 22:09:11 -08:00
2020-02-20 12:09:57 -08:00
2021-01-04 16:01:01 -08:00
2020-02-20 12:09:57 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-02-20 12:09:57 -08:00
2020-10-28 10:12:58 -07:00
2020-10-28 10:12:58 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-08-14 19:20:58 -07:00
2021-01-06 10:49:32 -08:00
2021-03-15 04:34:11 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2021-03-15 04:34:11 -07:00
2020-08-27 11:21:52 -07:00
2021-01-04 16:01:01 -08:00
2020-10-28 10:12:58 -07:00
2020-02-20 12:09:57 -08:00
2020-12-22 23:45:58 -08:00
2020-08-12 17:31:23 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-10-28 23:22:27 -07:00
2020-12-14 14:07:52 -08:00
2020-06-09 16:51:23 -07:00
2021-03-10 10:59:44 -08:00
2021-03-10 10:59:44 -08:00
2021-01-19 19:27:53 -08:00
2021-01-20 20:29:04 -08:00
2021-01-27 18:46:15 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-12-09 16:02:12 -08:00
2020-12-09 16:02:12 -08:00
2020-12-09 16:02:12 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-08-12 17:31:23 -07:00
2020-02-20 12:09:57 -08:00
2021-01-29 12:18:58 -08:00
2020-12-08 15:55:04 -08:00
2021-03-15 04:34:11 -07:00
2020-12-22 23:45:58 -08:00
2020-02-20 12:09:57 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2021-01-29 12:18:58 -08:00
2021-01-29 12:18:58 -08:00