Andrew Kryczka
60f5a22cff
Do not attempt to rename non-existent info log ( #8622 )
...
Summary:
Previously we attempted to rename "LOG" to "LOG.old.*" without checking
its existence first. "LOG" had no reason to exist in a new DB.
Errors in renaming a non-existent "LOG" were swallowed via
`PermitUncheckedError()` so things worked. However the storage service's
error monitoring was detecting all these benign rename failures. So it
is better to fix it. Also with this PR we can now distinguish rename failure
for other reasons and return them.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8622
Test Plan: new unit test
Reviewed By: akankshamahajan15
Differential Revision: D30115189
Pulled By: ajkr
fbshipit-source-id: e2f337ffb2bd171be0203172abc8e16e7809b170
2021-08-04 17:26:19 -07:00
..
2021-06-28 08:13:29 -07:00
2021-07-01 19:18:55 -07:00
2021-08-04 11:24:41 -07:00
2021-06-16 16:51:38 -07:00
2021-06-16 16:51:38 -07:00
2021-07-02 05:23:02 -07:00
2021-06-18 04:57:27 -07:00
2021-07-09 16:22:48 -07:00
2021-07-09 16:22:48 -07:00
2021-06-15 03:43:48 -07:00
2021-08-04 11:00:18 -07:00
2021-08-04 11:00:18 -07:00
2021-03-29 17:10:42 -07:00
2020-10-28 23:22:27 -07:00
2021-05-05 14:00:17 -07:00
2021-06-15 03:43:48 -07:00
2021-02-06 22:34:30 -08:00
2021-05-13 22:58:40 -07:00
2021-07-16 14:13:08 -07:00
2021-07-07 11:14:05 -07:00
2021-07-07 11:14:05 -07:00
2021-07-07 11:14:05 -07:00
2021-01-25 22:09:11 -08:00
2021-01-09 09:44:34 -08:00
2021-05-05 12:54:46 -07:00
2021-07-15 17:49:13 -07:00
2021-01-19 13:47:48 -08:00
2020-06-15 10:47:02 -07:00
2020-08-17 18:42:25 -07:00
2021-01-06 14:15:02 -08:00
2021-05-05 14:00:17 -07:00
2021-06-16 16:51:38 -07:00
2021-06-16 16:51:38 -07:00
2021-06-16 16:51:38 -07:00
2021-07-07 11:14:05 -07:00
2021-01-29 12:18:58 -08:00
2021-01-25 22:09:11 -08:00
2020-12-09 21:21:16 -08:00
2021-05-05 14:00:17 -07:00
2021-06-10 12:58:37 -07:00
2020-12-08 15:55:04 -08:00
2021-05-11 06:47:22 -07:00
2021-04-14 12:05:47 -07:00
2021-05-21 14:03:44 -07:00
2021-07-12 09:23:45 -07:00
2021-04-15 20:18:57 -07:00
2020-12-22 23:45:58 -08:00
2020-12-22 23:45:58 -08:00
2021-01-06 14:15:02 -08:00
2021-07-01 19:18:55 -07:00
2021-07-16 07:58:51 -07:00
2021-08-04 17:26:19 -07:00
2021-07-07 11:14:05 -07:00
2021-07-07 11:14:05 -07:00
2021-06-10 11:02:43 -07:00
2021-07-07 11:14:05 -07:00
2020-08-17 18:42:25 -07:00
2021-04-21 13:54:02 -07:00
2020-12-22 15:09:39 -08:00
2020-10-28 23:22:27 -07:00
2020-12-02 13:00:53 -08:00
2021-03-25 21:18:08 -07:00
2020-12-22 15:09:39 -08:00
2021-06-11 14:48:28 -07:00
2021-06-11 14:48:28 -07:00
2021-03-25 21:18:08 -07:00
2021-05-21 17:11:32 -07:00
2020-08-25 10:46:11 -07:00
2020-02-20 12:09:57 -08:00
2021-05-18 19:33:55 -07:00
2021-05-18 19:33:55 -07:00
2021-03-15 04:34:11 -07:00
2021-07-07 11:14:05 -07:00
2020-12-22 23:45:58 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-10-28 23:22:27 -07:00
2021-08-04 11:24:41 -07:00
2021-07-15 17:49:13 -07:00
2021-07-15 17:49:13 -07:00
2020-02-20 12:09:57 -08:00
2021-03-19 12:09:47 -07:00
2020-02-20 12:09:57 -08:00
2021-03-25 21:18:08 -07:00
2020-04-15 17:40:44 -07:00
2021-01-25 22:09:11 -08:00
2021-03-15 04:34:11 -07:00
2020-12-23 16:55:53 -08:00
2021-07-16 14:13:08 -07:00
2021-07-16 14:13:08 -07:00
2021-06-16 16:51:38 -07:00
2021-01-29 12:18:58 -08:00
2021-08-04 11:24:41 -07:00
2020-02-20 12:09:57 -08:00
2020-11-30 18:11:38 -08:00
2020-08-26 10:39:20 -07:00
2021-01-04 16:01:01 -08:00
2021-06-25 00:47:17 -07:00
2021-03-19 12:09:47 -07:00
2020-02-20 12:09:57 -08:00
2021-03-19 12:09:47 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-12-22 23:45:58 -08:00
2021-08-04 11:24:41 -07:00
2021-08-04 11:24:41 -07:00
2021-08-04 11:24:41 -07:00
2021-07-15 17:49:13 -07:00
2021-07-15 17:49:13 -07:00
2021-05-10 12:50:25 -07:00
2020-02-20 12:09:57 -08:00
2021-06-24 18:11:30 -07:00
2021-06-24 18:11:30 -07:00
2020-02-20 12:09:57 -08:00
2021-01-21 13:13:02 -08:00
2021-06-22 09:49:44 -07:00
2020-12-23 16:55:53 -08:00
2020-11-10 23:42:13 -08:00
2021-05-19 21:41:31 -07:00
2021-03-15 04:34:11 -07:00
2021-01-25 22:09:11 -08:00
2021-03-15 04:34:11 -07:00
2021-01-25 22:09:11 -08:00
2020-02-20 12:09:57 -08:00
2021-05-05 14:00:17 -07:00
2020-02-20 12:09:57 -08:00
2021-03-15 04:34:11 -07:00
2021-03-15 04:34:11 -07:00
2020-02-20 12:09:57 -08:00
2020-10-28 10:12:58 -07:00
2021-03-25 21:18:08 -07:00
2020-02-20 12:09:57 -08:00
2021-06-18 04:57:27 -07:00
2021-06-18 04:57:27 -07:00
2020-08-14 19:20:58 -07:00
2021-03-17 20:44:49 -07:00
2021-07-15 17:49:13 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2021-03-25 21:18:08 -07:00
2021-06-10 11:02:43 -07:00
2021-06-10 11:02:43 -07:00
2021-05-17 18:28:39 -07:00
2021-03-25 15:00:45 -07:00
2021-07-06 10:14:32 -07:00
2020-12-22 23:45:58 -08:00
2020-08-12 17:31:23 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2021-06-22 09:49:44 -07:00
2021-04-19 11:56:14 -07:00
2021-04-19 11:56:14 -07:00
2021-07-15 17:49:13 -07:00
2021-06-10 12:55:20 -07:00
2021-01-19 19:27:53 -08:00
2021-05-17 15:15:23 -07:00
2021-05-17 15:15:23 -07:00
2021-06-22 09:49:44 -07:00
2021-07-15 17:49:13 -07:00
2021-07-15 17:49:13 -07:00
2020-12-09 16:02:12 -08:00
2020-12-09 16:02:12 -08:00
2020-12-09 16:02:12 -08:00
2021-06-10 11:02:43 -07:00
2021-04-22 20:43:54 -07:00
2020-08-12 17:31:23 -07:00
2020-02-20 12:09:57 -08:00
2021-01-29 12:18:58 -08:00
2021-05-05 14:00:17 -07:00
2021-03-15 04:34:11 -07:00
2021-07-07 11:14:05 -07:00
2020-02-20 12:09:57 -08:00
2021-03-18 09:47:31 -07:00
2021-03-18 09:47:31 -07:00
2021-03-18 09:47:31 -07:00
2021-04-21 13:54:02 -07:00
2021-06-18 17:14:51 -07:00