andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
A library that provides an embeddable, persistent key-value store for fast storage.
7,026 Commits 152 Branches 236 Tags 271 MiB
C++ 82.1%
Java 10.3%
C 2.5%
Python 1.7%
Perl 1.1%
Other 2.1%
6f5e6445d9
Go to file
Maysam Yabandeh 6f5e6445d9 WritePrepared Txn: fix smallest_prep atomicity issue 
Summary:
We introduced smallest_prep optimization in this commit b225de7e10, which enables storing the smallest uncommitted sequence number along with the snapshot. This enables the readers that read from the snapshot to skip further checks and safely assumed the data is committed if its sequence number is less than smallest uncommitted when the snapshot was taken. The problem was that smallest uncommitted and the snapshot must be taken atomically, and the lack of atomicity had led to readers using a smallest uncommitted after the snapshot was taken and hence mistakenly skipping some data.
This patch fixes the problem by i) separating the process of removing of prepare entries from the AddCommitted function, ii) removing the prepare entires AFTER the committed sequence number is published, iii) getting smallest uncommitted (from the prepare list) BEFORE taking a snapshot. This guarantees that the smallest uncommitted that is accompanied with a snapshot is less than or equal of such number if it was obtained atomically.

Tested by running MySQLStyleTransactionTest/MySQLStyleTransactionTest.TransactionStressTest that was failing sporadically.
Closes https://github.com/facebook/rocksdb/pull/3703

Differential Revision: D7581934

Pulled By: maysamyabandeh

fbshipit-source-id: dc9d6f4fb477eba75d4d5927326905b548a96a32
2018-04-11 20:11:51 -07:00
buckifier Update buckifier and TARGETS 2018-03-30 14:26:53 -07:00
build_tools Some small improvements to the build_tools 2018-04-02 23:57:41 -07:00
cache Clock cache should check if deleter is nullptr before calling it 2018-04-05 11:57:53 -07:00
cmake add missing config checks to CMakeLists.txt 2017-11-30 22:57:00 -08:00
coverage Suppress lint in old files 2018-01-29 12:56:42 -08:00
db Improve visibility into the reasons for compaction. 2018-04-11 10:58:44 -07:00
docs Adding blog post for 5.10.2 release 2018-02-13 11:56:59 -08:00
env Fix some typos in comments and docs. 2018-03-08 10:27:25 -08:00
examples Pinnableslice examples and blog post 2017-08-24 12:26:07 -07:00
hdfs Comment out unused variables 2018-03-05 13:13:41 -08:00
include/rocksdb Improve visibility into the reasons for compaction. 2018-04-11 10:58:44 -07:00
java Added support for SstFileManager to RocksJava 2018-04-06 21:26:32 -07:00
memtable InlineSkiplist: don't decode keys unnecessarily during comparisons 2018-03-23 12:14:30 -07:00
monitoring uint64_t and size_t changes to compile for iOS 2018-03-06 12:43:51 -08:00
options fix calling SetOptions on deprecated options 2018-04-10 19:02:09 -07:00
port CloseHandle docs says that the return is non-zero, does not say TRUE(1) 2018-03-20 18:43:02 -07:00
table Fix the memory leak with pinned partitioned filters 2018-04-09 16:28:19 -07:00
third-party fix some text in comments. 2018-04-10 15:59:24 -07:00
tools WritePrepared Txn: add write_committed option to dump_wal 2018-04-07 21:56:42 -07:00
util make MockTimeEnv::current_time_ atomic to fix data race 2018-04-10 14:13:18 -07:00
utilities WritePrepared Txn: fix smallest_prep atomicity issue 2018-04-11 20:11:51 -07:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore Remove leftover references to phutil_module_cache 2017-08-23 12:12:21 -07:00
.travis.yml add 4th test_group in travis 2018-03-13 18:57:29 -07:00
appveyor.yml Upgrade Appveyor to VS2017 2018-02-01 13:57:01 -08:00
AUTHORS Update RocksDB Authors File 2017-10-18 14:42:10 -07:00
CMakeLists.txt Fix 3-way SSE4.2 crc32c usage in MSVC with CMake 2018-04-02 20:42:26 -07:00
CODE_OF_CONDUCT.md Add Code of Conduct 2017-12-05 18:42:35 -08:00
CONTRIBUTING.md Add Code of Conduct 2017-12-05 18:42:35 -08:00
COPYING Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
DEFAULT_OPTIONS_HISTORY.md options.delayed_write_rate use the rate of rate_limiter by default. 2017-05-24 09:58:24 -07:00
DUMP_FORMAT.md First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
HISTORY.md Fix the memory leak with pinned partitioned filters 2018-04-09 16:28:19 -07:00
INSTALL.md Enable compilation on OpenBSD 2018-03-19 12:30:05 -07:00
issue_template.md Add a template for issues 2017-09-29 11:41:28 -07:00
LANGUAGE-BINDINGS.md Add Nim to the list of language bindings 2018-01-29 09:57:46 -08:00
LICENSE.Apache Change RocksDB License 2017-07-15 16:11:23 -07:00
LICENSE.leveldb Add back the LevelDB license file 2017-07-16 18:42:18 -07:00
Makefile fix shared libary compile on ppc 2018-04-05 19:58:20 -07:00
README.md Add dual-license info to README.md 2018-03-06 12:43:51 -08:00
ROCKSDB_LITE.md Fix some typos in comments and docs. 2018-03-08 10:27:25 -08:00
src.mk Added support for SstFileManager to RocksJava 2018-04-06 21:26:32 -07:00
TARGETS Update buckifier and TARGETS 2018-03-30 14:26:53 -07:00
thirdparty.inc Make Windows dep switches compatible with other builds 2018-01-05 14:56:54 -08:00
USERS.md Added ProfaneDB 2017-11-19 10:11:44 -08:00
Vagrantfile Adding CentOS 7 Vagrantfile & build script 2018-02-26 15:27:17 -08:00
WINDOWS_PORT.md Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00

README.md

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Linux/Mac Build Status Windows Build status PPC64le Build Status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/

License

RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.