andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
80b74a6c64
rocksdb/table
History
sdong 535af525d6 BlockBasedTable::PrefixMayMatch() to skip index checking if we can't find a filter block. 
Summary:
In the case where we can't find a filter block, there is not much benefit of doing the binary search and see whether the index key has the prefix. With the change, we blindly return true if we can't get the filter.
It also fixes missing row cases for reverse comparator with full bloom.

Test Plan: Add a test case that used to fail.

Reviewers: yhchiang, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: kradhakrishnan, yiwu, hermanlee4, yoshinorim, leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D56697
2016-04-13 19:06:48 -07:00
..
adaptive_table_factory.cc Pass column family ID to table property collector 2015-10-09 14:36:51 -07:00
adaptive_table_factory.h Pass column family ID to table property collector 2015-10-09 14:36:51 -07:00
block_based_filter_block_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_based_filter_block.cc Revert "Revert "Fixed the bug when both whole_key_filtering and prefix_extractor are set."" 2016-02-22 16:33:26 -08:00
block_based_filter_block.h Revert "Revert "Fixed the bug when both whole_key_filtering and prefix_extractor are set."" 2016-02-22 16:33:26 -08:00
block_based_table_builder.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
block_based_table_builder.h Embed column family name in SST file 2016-04-06 23:10:32 -07:00
block_based_table_factory.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
block_based_table_factory.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_based_table_reader.cc BlockBasedTable::PrefixMayMatch() to skip index checking if we can't find a filter block. 2016-04-13 19:06:48 -07:00
block_based_table_reader.h Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes. 2016-04-01 10:42:39 -07:00
block_builder.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_builder.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_hash_index_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_hash_index.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_hash_index.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_prefix_index.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_prefix_index.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
bloom_block.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
bloom_block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_builder_test.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
cuckoo_table_builder.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
cuckoo_table_builder.h Embed column family name in SST file 2016-04-06 23:10:32 -07:00
cuckoo_table_factory.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
cuckoo_table_factory.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_reader_test.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
cuckoo_table_reader.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_reader.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
filter_block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
flush_block_policy.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
format.cc to/from hex refactor 2016-03-30 14:36:48 -07:00
format.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
full_filter_block_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
full_filter_block.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
full_filter_block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
get_context.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
get_context.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
internal_iterator.h Add Iterator Property rocksdb.iterator.version_number 2016-03-02 16:23:59 -08:00
iter_heap.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
iterator_wrapper.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
iterator.cc Rename iterator property "rocksdb.iterator.is.key.pinned" => "rocksdb.iterator.is-key-pinned" 2016-03-01 13:47:12 -08:00
merger_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
merger.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
merger.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
meta_blocks.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
meta_blocks.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
mock_table.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
mock_table.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_builder.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
plain_table_builder.h Embed column family name in SST file 2016-04-06 23:10:32 -07:00
plain_table_factory.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
plain_table_factory.h Fix build broken by previous commit of "option helper refactor" 2015-11-17 16:52:54 -08:00
plain_table_index.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_index.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_key_coding.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_key_coding.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_reader.cc Skip bottom-level filter block caching when hit-optimized 2015-12-23 10:15:07 -08:00
plain_table_reader.h Skip bottom-level filter block caching when hit-optimized 2015-12-23 10:15:07 -08:00
scoped_arena_iterator.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
sst_file_writer.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
table_builder.h Embed column family name in SST file 2016-04-06 23:10:32 -07:00
table_properties_internal.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
table_properties.cc Add column family info to TableProperties::ToString() 2016-04-08 18:50:18 -07:00
table_reader_bench.cc Embed column family name in SST file 2016-04-06 23:10:32 -07:00
table_reader.h Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes. 2016-04-01 10:42:39 -07:00
table_test.cc PrefixTest.PrefixAndWholeKeyTest should run against a different directory from prefix_test 2016-04-11 13:02:56 -07:00
two_level_iterator.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
two_level_iterator.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00