Andrew Kryczka 8458532d58 Skip unnecessary allocation for mmap reads under 5000 bytes (#7043) ... Summary: With mmap enabled on an uncompressed file, we were previously always doing a heap allocation to obtain the scratch buffer for `RandomAccessFileReader::Read()`. However, that allocation was unnecessary as the underlying file reader returned a pointer into its mapped memory, not the provided scratch buffer. This PR makes passes the `BlockFetcher`'s inline buffer as the scratch buffer if the data block is small enough (less than `kDefaultStackBufferSize` bytes, currently 5000). Ideally we would not pass a scratch buffer at all for an mmap read; however, the `RandomAccessFile::Read()` API guarantees such a buffer is provided, and non-standard implementations may be relying on it even when `Options::allow_mmap_reads == true`. In that case, this PR still works but introduces an extra copy from the inline buffer to a heap buffer. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7043 Reviewed By: cheng-chang Differential Revision: D22320606 Pulled By: ajkr fbshipit-source-id: ad964dd23df34e07d979c6032c2dfe5454c98b52		2020-06-30 15:40:40 -07:00
..
adaptive	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
block_based	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
cuckoo	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
plain	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
block_fetcher_test.cc	Skip unnecessary allocation for mmap reads under 5000 bytes (#7043)	2020-06-30 15:40:40 -07:00
block_fetcher.cc	Skip unnecessary allocation for mmap reads under 5000 bytes (#7043)	2020-06-30 15:40:40 -07:00
block_fetcher.h	Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)	2020-04-24 15:32:56 -07:00
cleanable_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
format.cc	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
format.h	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
get_context.cc	Add timestamp to delete (#6253)	2020-05-28 10:40:03 -07:00
get_context.h	Stats for redundant insertions into block cache (#6681)	2020-04-27 13:20:27 -07:00
internal_iterator.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
iter_heap.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
iterator_wrapper.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
merger_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
merging_iterator.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
merging_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
meta_blocks.cc	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
meta_blocks.h	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
mock_table.cc	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
mock_table.h	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
multiget_context.h	Allow MultiGet users to limit cumulative value size (#6826)	2020-05-27 13:07:14 -07:00
persistent_cache_helper.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
persistent_cache_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
persistent_cache_options.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_dumper.cc	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
sst_file_dumper.h	Add a new option for BackupEngine to store table files under shared_checksum using DB session id in the backup filenames (#6997)	2020-06-24 19:31:25 -07:00
sst_file_reader_test.cc	Allow table/sst_file_reader_test.cc to use custom Env (#6536)	2020-03-17 11:02:13 -07:00
sst_file_reader.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_writer_collectors.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_writer.cc	Store DB identity and DB session ID in SST files (#6983)	2020-06-17 10:57:40 -07:00
table_builder.h	Store DB identity and DB session ID in SST files (#6983)	2020-06-17 10:57:40 -07:00
table_properties_internal.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_properties.cc	Store DB identity and DB session ID in SST files (#6983)	2020-06-17 10:57:40 -07:00
table_reader_bench.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_reader_caller.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_reader.h	For ApproximateSizes, pro-rate table metadata size over data blocks (#6784)	2020-06-02 12:30:23 -07:00
table_test.cc	Extend Get/MultiGet deadline support to table open (#6982)	2020-06-29 14:53:17 -07:00
two_level_iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
two_level_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00