andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
aa734ce9ab
rocksdb/table
History
kailiu aa734ce9ab Fix a member variables initialization order issue 
Summary:
In MacOS, I got issue with `Footer`'s default constructor, which initialized the magic number with some random number instead of 0.
With investigation, I found we forgot to make the kInvalidTableMagicNumber to be static. As a result, kInvalidTableMagicNumber was assgined to `table_magic_number_` before it is initialized (which will be populated with random number).

Test Plan: passed current unit tests; also passed the unit tests for the incoming diff which used the default footer.

Reviewers: yhchiang

CC: leveldb

Differential Revision: https://reviews.facebook.net/D16077
2014-02-11 14:16:46 -08:00
..
block_based_table_builder.cc Support for LZ4 compression. 2014-02-08 14:15:51 -08:00
block_based_table_builder.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block_based_table_factory.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block_based_table_factory.h Put table factory back to public api 2014-02-03 19:51:20 -08:00
block_based_table_reader.cc Make table properties shareable 2014-02-07 19:26:49 -08:00
block_based_table_reader.h Make table properties shareable 2014-02-07 19:26:49 -08:00
block_builder.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block_builder.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block_test.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block.cc Implement a compressed block cache. 2013-11-01 14:31:35 -07:00
block.h Implement a compressed block cache. 2013-11-01 14:31:35 -07:00
filter_block_test.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
filter_block.cc Merge branch 'master' into performance 2014-02-05 21:21:00 -08:00
filter_block.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
flush_block_policy.cc Don't not suggest flushing data when data block is still empty 2013-11-11 21:05:16 -08:00
format.cc Merge pull request #74 from alberts/lz4 2014-02-10 15:46:56 -08:00
format.h Fix a member variables initialization order issue 2014-02-11 14:16:46 -08:00
iter_heap.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
iterator_wrapper.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
iterator.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
merger.cc Revert "Allow users to profile a query and see bottleneck of the query" 2013-11-21 17:40:39 -08:00
merger.h Merge branch 'master' into performance 2014-01-28 10:35:55 -08:00
meta_blocks.cc Make table properties shareable 2014-02-07 19:26:49 -08:00
meta_blocks.h Make table properties shareable 2014-02-07 19:26:49 -08:00
plain_table_builder.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
plain_table_builder.h First phase API clean up 2014-02-03 00:30:43 -08:00
plain_table_factory.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
plain_table_factory.h Put table factory back to public api 2014-02-03 19:51:20 -08:00
plain_table_reader.cc Make table properties shareable 2014-02-07 19:26:49 -08:00
plain_table_reader.h Make table properties shareable 2014-02-07 19:26:49 -08:00
table_builder.h First phase API clean up 2014-02-03 00:30:43 -08:00
table_properties.cc Add support for plain table format to sst_dump. 2014-02-07 11:15:00 -08:00
table_reader_bench.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
table_reader.h Make table properties shareable 2014-02-07 19:26:49 -08:00
table_test.cc Quick fix for table_test failure 2014-02-10 17:05:14 -08:00
two_level_iterator.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
two_level_iterator.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00