andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/db
History
krad d4540654e9 Optimize GetApproximateSizes() to use lesser CPU cycles. 
Summary:
CPU profiling reveals GetApproximateSizes as a bottleneck for performance. The current implementation is sub-optimal, it scans every file in every level to compute the result.

We can take advantage of the fact that all levels above 0 are sorted in the increasing order of key ranges and use binary search to locate the starting index. This can reduce the number of comparisons required to compute the result.

Test Plan: We have good test coverage. Run the tests.

Reviewers: sdong, igor, rven, dynamike

Subscribers: dynamike, maykov, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D37755
2015-04-30 10:55:03 -07:00
..
builder.cc
options.paranoid_file_checks to read all rows after writing to a file.
2015-04-23 11:34:35 -07:00
builder.h
options.paranoid_file_checks to read all rows after writing to a file.
2015-04-23 11:34:35 -07:00
c_test.c
rocksdb: Fixed 'Dead assignment' and 'Dead initialization' scan-build warnings
2015-02-23 14:10:09 -08:00
c.cc
Deprecate removeScanCountLimit in NewLRUCache
2015-03-17 15:04:37 -07:00
column_family_test.cc
fix typos
2015-04-25 18:14:27 +09:00
column_family.cc
fix typos
2015-04-25 18:14:27 +09:00
column_family.h
Fix CompactRange for universal compaction with num_levels > 1
2015-04-23 19:12:31 -07:00
compact_files_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
compaction_job_test.cc
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
compaction_job.cc
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
compaction_job.h
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
compaction_picker_test.cc
Add experimental API MarkForCompaction()
2015-04-17 16:44:45 -07:00
compaction_picker.cc
fix typos
2015-04-25 18:14:27 +09:00
compaction_picker.h
Add experimental API MarkForCompaction()
2015-04-17 16:44:45 -07:00
compaction.cc
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
compaction.h
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
comparator_db_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
corruption_test.cc
fix typos
2015-04-25 18:14:27 +09:00
cuckoo_table_db_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
db_bench.cc
Fixes for readcache-flashcache
2015-04-09 15:51:34 -07:00
db_filesnapshot.cc
Don't delete files when column family is dropped
2015-03-19 17:04:29 -07:00
db_impl_debug.cc
Clean up old log files in background threads
2015-03-30 15:04:10 -04:00
db_impl_experimental.cc
Don't compact bottommost level in SuggestCompactRange
2015-04-29 13:35:48 -07:00
db_impl_readonly.cc
Move GetThreadList() feature under Env.
2014-12-22 12:20:17 -08:00
db_impl_readonly.h
Block ReadOnlyDB in ROCKSDB_LITE
2014-11-26 11:37:59 -08:00
db_impl.cc
Optimize GetApproximateSizes() to use lesser CPU cycles.
2015-04-30 10:55:03 -07:00
db_impl.h
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
db_iter_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
db_iter.cc
fix typos
2015-04-25 18:14:27 +09:00
db_iter.h
reduce references to cfd->options() in DBImpl
2014-09-08 15:04:34 -07:00
db_test.cc
Don't compact bottommost level in SuggestCompactRange
2015-04-29 13:35:48 -07:00
dbformat_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
dbformat.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
dbformat.h
Abstract out SetMaxPossibleForUserKey() and SetMinPossibleForUserKey
2015-04-23 18:08:37 -07:00
deletefile_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
experimental.cc
Implement DB::PromoteL0 method
2015-04-23 12:10:36 -07:00
fault_injection_test.cc
fault_injection_test: add a test case to cover log syncing after a log roll
2015-04-09 16:15:42 -07:00
file_indexer_test.cc
Fix possible SIGSEGV in CompactRange (github issue #596)
2015-04-29 10:52:31 -07:00
file_indexer.cc
Fix possible SIGSEGV in CompactRange (github issue #596)
2015-04-29 10:52:31 -07:00
file_indexer.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
filename_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
filename.cc
Sync manifest file when initializing it
2015-01-22 14:32:03 -08:00
filename.h
Sync manifest file when initializing it
2015-01-22 14:32:03 -08:00
flush_job_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
flush_job.cc
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
flush_job.h
Allow GetThreadList() to report operation stage.
2015-03-13 10:45:40 -07:00
flush_scheduler.cc
Don't return (or dereference) dangling pointer
2014-10-02 14:33:16 -07:00
flush_scheduler.h
Fix data race #1
2015-01-26 11:48:07 -08:00
forward_iterator.cc
rocksdb: Add missing override
2015-02-26 11:28:41 -08:00
forward_iterator.h
rocksdb: Add missing override
2015-02-26 11:28:41 -08:00
internal_stats.cc
Fix make unity build compiler warning about "stats" shadowing global variable
2015-04-01 10:48:42 -07:00
internal_stats.h
Fix a compilation error in ROCKSDB_LITE in db/internal_stats.h
2015-04-09 16:43:54 -07:00
job_context.h
Clean up old log files in background threads
2015-03-30 15:04:10 -04:00
listener_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
log_format.h
Some minor refactoring on the code
2014-01-02 16:32:31 -08:00
log_reader.cc
rocksdb: Fixed 'Dead assignment' and 'Dead initialization' scan-build warnings
2015-02-23 14:10:09 -08:00
log_reader.h
Log writer record format doc.
2015-04-07 16:25:56 -07:00
log_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
log_writer.cc
fix erroneous assert: cast kBlockSize (of type unsigned int) to "int"
2015-02-20 11:07:17 -08:00
log_writer.h
Log writer record format doc.
2015-04-07 16:25:56 -07:00
managed_iterator.cc
Fix compile error on MacOS.
2015-02-24 16:24:53 -08:00
managed_iterator.h
Fixed xfunc related compile errors in ROCKSDB_LITE
2015-04-09 21:05:18 -07:00
memtable_allocator.cc
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
memtable_allocator.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
memtable_list_test.cc
Include bunch of more events into EventLogger
2015-04-27 15:20:02 -07:00
memtable_list.cc
fix typos
2015-04-25 18:14:27 +09:00
memtable_list.h
Fix valgrind issues in memtable_list_test
2015-04-10 14:16:03 -07:00
memtable.cc
Adding stats for the merge and filter operation
2015-03-24 14:42:04 -07:00
memtable.h
Add thread-safety documentation to MemTable and related classes
2015-04-08 21:10:35 -07:00
memtablerep_bench.cc
Fix clang build
2015-01-13 12:27:28 -08:00
merge_context.h
Enhance partial merge to support multiple arguments
2014-03-24 17:57:13 -07:00
merge_helper.cc
Helper function to time Merges
2015-04-27 20:23:50 -07:00
merge_helper.h
Helper function to time Merges
2015-04-27 20:23:50 -07:00
merge_operator.cc
Some small cleaning up to make some compiling environment happy
2014-03-26 18:11:41 -07:00
merge_test.cc
rocksdb: Add missing override
2015-02-26 11:28:41 -08:00
perf_context_test.cc
Makefile minor cleanup
2015-03-30 16:05:35 -04:00
plain_table_db_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
prefix_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
repair.cc
options.paranoid_file_checks to read all rows after writing to a file.
2015-04-23 11:34:35 -07:00
skiplist_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
skiplist.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
slice.cc
Create an abstract interface for write batches
2015-03-17 19:23:08 -07:00
snapshot.h
rocksdb: Add missing override
2015-02-26 11:28:41 -08:00
table_cache.cc
TableMock + framework for mock classes
2014-10-28 17:52:32 -07:00
table_cache.h
use GetContext to replace callback function pointer
2014-09-29 11:09:09 -07:00
table_properties_collector_test.cc
A new call back to TablePropertiesCollector to allow users know the entry is add, delete or merge
2015-04-06 10:27:21 -07:00
table_properties_collector.cc
A new call back to TablePropertiesCollector to allow users know the entry is add, delete or merge
2015-04-06 10:27:21 -07:00
table_properties_collector.h
A new call back to TablePropertiesCollector to allow users know the entry is add, delete or merge
2015-04-06 10:27:21 -07:00
transaction_log_impl.cc
Turn -Wshadow back on
2014-11-06 11:14:28 -08:00
transaction_log_impl.h
rocksdb: Add missing override
2015-02-26 11:28:41 -08:00
version_builder_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
version_builder.cc
Fix deleting obsolete files
2015-02-06 08:44:30 -08:00
version_builder.h
Move VersionBuilder logic to a separate .cc file
2014-10-31 16:34:38 -07:00
version_edit_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
version_edit.cc
Turn on -Wshadow
2014-10-31 11:59:54 -07:00
version_edit.h
Add experimental API MarkForCompaction()
2015-04-17 16:44:45 -07:00
version_set_test.cc
Fix level size overflow for options_.level_compaction_dynamic_level_bytes=true
2015-04-03 09:04:35 -07:00
version_set.cc
Optimize GetApproximateSizes() to use lesser CPU cycles.
2015-04-30 10:55:03 -07:00
version_set.h
Optimize GetApproximateSizes() to use lesser CPU cycles.
2015-04-30 10:55:03 -07:00
wal_manager_test.cc
Fix flakiness of WalManagerTest
2015-04-13 16:15:05 -07:00
wal_manager.cc
rocksdb: Add missing override
2015-02-26 11:28:41 -08:00
wal_manager.h
Fix -Wnon-virtual-dtor errors
2014-11-10 17:39:38 -05:00
write_batch_base.cc
Create an abstract interface for write batches
2015-03-17 19:23:08 -07:00
write_batch_internal.h
remove all remaining references to cfd->options()
2014-11-18 10:20:10 -08:00
write_batch_test.cc
rocksdb: Remove #include "util/string_util.h" from util/testharness.h
2015-03-19 17:29:37 -07:00
write_batch.cc
Adding stats for the merge and filter operation
2015-03-24 14:42:04 -07:00
write_controller_test.cc
maint: use ASSERT_TRUE, not ASSERT_EQ(true; same for false
2015-04-17 14:54:17 -07:00
write_controller.cc
Push- instead of pull-model for managing Write stalls
2014-09-08 11:20:25 -07:00
write_controller.h
Fix #284
2014-09-13 14:14:10 -07:00
write_thread.cc
WriteThread
2014-09-12 16:23:58 -07:00
write_thread.h
Add a counter for collecting the wait time on db mutex.
2015-02-04 21:39:45 -08:00
writebuffer.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00