Go to file
Adam Jackson 516e75dbb6 dix: Call SourceValidate before GetImage
This ensures that any prep work for the drawable we're about to read
from is already done before we call down to GetImage. This should be no
functional change as most of the callers with a non-trivial
SourceValidate are already wrapping GetImage and doing the equivalent
thing, but we'll be simplifying that shortly.

More importantly this ensures that if any of that prep work would
generate events - like automatic compositing flushing rendering to a
parent pixmap which then triggers damage - then it happens entirely
before we start writing the GetImage reply header.

Note that we do not do the same for GetSpans, but that's okay. The only
way to get to GetSpans is through miCopyArea or miCopyPlane - where the
callers must already call SourceValidate - or miGetImage - which this
commit now protects with SourceValidate.

Fixes: xorg/xserver#902
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
2019-10-30 16:26:01 +00:00
.gitlab-ci gitlab-ci: Add a manpage substitutions regression test 2019-10-04 10:34:38 +02:00
composite mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
config udev: Fixed NULL pointer argument of strcmp 2019-09-20 05:33:47 +00:00
damageext Use ARRAY_SIZE all over the tree 2017-10-30 13:45:20 -04:00
dbe meson: Distribute more SDK headers 2018-04-02 13:42:08 -04:00
dix dix: Call SourceValidate before GetImage 2019-10-30 16:26:01 +00:00
doc mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
dri3 dri3: Fix XACE access mode for open and get_supported_modifiers 2019-01-16 20:05:43 +00:00
exa mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
fb fboverlay: move bpp checks above malloc 2018-09-12 12:26:48 +10:00
glamor Revert https://gitlab.freedesktop.org/xorg/xserver/merge_requests/235 2019-10-14 12:48:24 +02:00
glx dix: Call SourceValidate before GetImage 2019-10-30 16:26:01 +00:00
hw mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
include include: Remove now-empty site.h 2019-10-30 16:17:04 +00:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man dix: Remove -to option to set the default connection timeout 2019-10-30 16:17:04 +00:00
mi mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
miext mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
os include: Remove now-empty site.h 2019-10-30 16:17:04 +00:00
present Revert "present/scmd: Check that the flip and screen pixmap pitches match" 2019-07-03 11:53:56 +02:00
pseudoramiX Unvalidated lengths 2017-10-10 23:33:34 +02:00
randr xf86: autobind GPUs to the screen 2019-08-07 12:26:59 +02:00
record record: Fix undefined memcpy in RecordAClientStateChange 2019-10-15 14:06:44 -04:00
render dix: Call SourceValidate before GetImage 2019-10-30 16:26:01 +00:00
test xfree86: Link fb statically 2019-07-23 14:24:00 -04:00
Xext dix: Call SourceValidate before GetImage 2019-10-30 16:26:01 +00:00
xfixes xfixes: Restore monitoring of animated cursors 2018-02-14 13:52:45 -05:00
Xi Xi: return AlreadyGrabbed for key grabs > 255 2019-06-12 16:58:53 +00:00
xkb Fix crash on XkbSetMap 2019-07-01 02:33:26 +02:00
.appveyor.yml Revert "appveyor: Drop building Xorg server" 2019-10-08 18:26:33 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml gitlab-ci: Add a manpage substitutions regression test 2019-10-04 10:34:38 +02:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
autogen.sh autogen: Set a default subject prefix for patches 2016-02-08 17:41:38 -05:00
configure.ac configure: Set libdrm flags correctly if only XORG is enabled 2019-10-29 20:45:15 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
devbook.am doc: Create a script to filter xmlto output 2015-01-05 14:24:06 -08:00
docbook.am docbook.am: embed css styles inside the HTML HEAD element 2011-09-21 14:07:49 -07:00
Makefile.am xfree86: Merge vbe into int10 2019-10-02 10:03:26 -04:00
manpages.am man: Fix automake seddery 2018-05-08 12:15:30 -04:00
meson_options.txt xfree86: Merge vbe into int10 2019-10-02 10:03:26 -04:00
meson.build Revert https://gitlab.freedesktop.org/xorg/xserver/merge_requests/235 2019-10-14 12:48:24 +02:00
README.md Update README for gitlab migration 2018-11-25 20:55:11 +00:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The master development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct