Commit Graph

15692 Commits

Author SHA1 Message Date
Nate Graham
7f9fe64f9b Fix plasmoidheading.svgz being installed to the wrong place
This was causing it to not show up for people using the Breeze Dark
Plasma theme (but not the default Plasma theme with a dark color scheme)

BUG: 426537
FIXED-IN: 5.75
CCMAIL: vonreth@kde.org
2020-10-01 17:28:54 -06:00
Arjen Hiemstra
2f78dfb9d9 Provide a lastModified value in ThemeTest
Since lastModified is now required to be a valid value we should make
sure to test with a proper value as well.
2020-10-01 15:11:19 +00:00
Aleix Pol
93de15f545 Detect that we are looking for an empty element and quit early
Otherwise we just go through all the fallbacks unnecessarily
2020-10-01 12:14:41 +00:00
Nicolas Fella
fe7598c6ef Remove commented code 2020-09-30 22:40:04 +02:00
Nate Graham
b532fd2f20 Make PlasmaComponents3 Tooltips use the typical tooltip style
Without this, the tooltips are light when using a light theme. This is
contrary to other tooltips, which are always dark no matter which
coloration of theme you're using.

BUG: 424506
FIXED-IN: 5.75
2020-09-28 08:44:41 -06:00
Nate Graham
b40a1fbdf0 Use Header colors in PlasmoidHeading headers
This brings applets with distinct heading areas into visual consistency
with windows, once the Tools Area MR lands.

When using a color scheme that lacks Header colors, there is no visual
change whatsoever.
2020-09-28 14:30:18 +00:00
l10n daemon script
f47f98da0b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-28 05:58:18 +02:00
andy salerno
ad6647d5e5 Change PC2 TabBar highlight movement animation easing type to OutCubic
This makes the highlight movement feel more responsive in Kickoff.

Unfortunately, the same cannot be done for the PC3 TabBar since it uses
a ListView with a highlight. The easing type for the highlight movement
animation cannot be customized.

MR: frameworks/plasma-framework!91
2020-09-26 15:20:26 -03:00
Noah Davis
b8fb2ff44e Add support for Tooltip color set
Also add some missing color sets to ThemePrivate::colorsChanged()
2020-09-24 16:41:13 -04:00
Noah Davis
3167717797 Fix PC3 Button/ToolButton icons not always having the right color set
BUG: 426556
FIXED-IN: 5.75
2020-09-23 20:33:46 -04:00
Arjen Hiemstra
16f852ea4c Ensure FrameSvg uses lastModified timestamp when using cache
This, I suspect, is the true source of bug 426674. FrameSvg would
request items from the cache without specifying any modification time
stamp, so we end up always retrieving the cached version. Since
lastModified is now a required parameter, we need to ensure this does
not happen anymore.

BUG: 426674
2020-09-23 14:08:52 +00:00
Arjen Hiemstra
7b42e5b45d Ensure we always have a valid lastModified timestamp when setImagePath is called
Not tracking modification time of icon/themed stuff means we do not know
when we need to reject the cached versions of these. So ensure we try to
keep track of the svg that this is coming from, even if we do stuff to
it in the meantime.

Longer term this should be changed so the cache knows which files it is
caching and can reject things that changed in the meantime.
2020-09-23 14:08:52 +00:00
Arjen Hiemstra
54e12fcda0 Deprecate a lastModified timestamp of 0 in Theme::findInCache
lastModified is used to track whether a file is outdated. Having a 0
here means we (in the old code) use the cached version. This causes
problems when the on-disk file has changed, as we have no way of
informing callers that they should regenerate the cache entry. To avoid
this, using a lastModified of 0 now warns and will always return false
(to indicate it is not cached). Unfortunately we can't simply drop the
default parameter of 0 since there is no source-compatible way of doing
that.

CCBUG: 426674
2020-09-23 14:08:52 +00:00
Jonah Brüchert
c0ebacfa68 Adapt QQC2 import to new versioning scheme
The minor version of QQC2 is now the same as the Qt minor version.
2020-09-23 07:05:30 +00:00
l10n daemon script
6885e1176b SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-23 06:25:34 +02:00
Hartmut Goebel
ff5ed26f21 Fix build errors if PREFIX is different from ECM's PREFIX.
See <https://bugs.kde.org/424483> for details
2020-09-22 10:23:28 +00:00
David Edmundson
4a9e57b7df [windowthumbnail] Verify that the relevant GLContext exists, not any
glXGetCurrentContext checks if any GLContext exists and is current.

resolveGLXFunctions uses window->openglContext()

One can hit a situation that you are using software rendering for the
window, yet someone else has created a GL Context. This then crashes.
2020-09-22 10:20:57 +00:00
Nate Graham
36247d97c4 Add missing PlasmaCore import to ButtonRow.qml 2020-09-21 17:08:01 -06:00
l10n daemon script
329ea4b4ff SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-20 05:41:08 +02:00
Noah Davis
fb883e2740 Improve the accuracy of Units.gridUnit documentation
It never held the width of an 'M', it held the height of a boundingRect that happened to contain an 'M'. The fact that there is an 'M' doesn't really matter since the bounding rect is much taller.
2020-09-19 09:58:43 -04:00
Nate Graham
a7aeba21c4 Fix a few more reference errors in PlasmaExtras.ListItem 2020-09-17 12:51:51 -06:00
Nate Graham
39d824796c Fix error for implicitBackgroundWidth in PlasmaExtras.ListItem 2020-09-17 12:18:40 -06:00
l10n daemon script
1be54dfc61 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-13 05:57:29 +02:00
l10n daemon script
b8ea2cc5a9 GIT_SILENT Upgrade KF5 version to 5.75.0. 2020-09-12 11:49:40 +00:00
l10n daemon script
f0873cd077 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-10 06:21:08 +02:00
l10n daemon script
cdfc7512aa SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-08 06:34:57 +02:00
l10n daemon script
973051ef3d SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-07 05:56:59 +02:00
Nate Graham
1aaccc2aef Call edit mode "Edit Mode"
This came up in yesterday's VDG meeting.

When we introduced the idea of an edit mode. We kind of danced areound
what it is, and didn't call it a mode, even though it is. We named the
menu item "Customize layout". However in all of our communications with
the user outside of the UI, we call it the global edit mode. Users
themselves call it "mdit mode". The code calls it "edit mode". We call
it edit mode when we talk about it internally. I think it's pretty clear
what it is in people's minds. So let's make the UI text reflect that.
2020-09-06 16:13:14 +00:00
Felix Yan
c5a8ed1a88 Fix a TypeError in QueryDialog.qml 2020-09-06 15:15:41 +00:00
Felix Yan
e424330089 Fix ReferenceError to PlasmaCore in Button.qml 2020-09-06 13:32:58 +00:00
l10n daemon script
1e430666c2 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.74.0 release. 2020-09-06 09:36:30 +00:00
l10n daemon script
cfaf383f89 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-09-06 05:47:09 +02:00
David Edmundson
7b6191f440 [PC3/BusyIndicator] Avoid running invisible animation
Running is a property managed by a state machine. It is bound in the
transition between states. We don't run a transition to get to the first
state.

These transitions aren't needed and can be written away simplifying the
code considerably in the process.

This means krunner is invisibly animating at 60fps constantly even when
it's not doing anything.
2020-09-05 14:13:26 +01:00
Noah Davis
37a95de3f3 Add missing license headers 2020-09-01 12:53:40 +00:00
Nicolas Fella
107776b239 Drop empty X-KDE-PluginInfo-Depends
The whole concept is almost unused and there's no point in having it there but empty

See also https://phabricator.kde.org/T13553
2020-09-01 02:09:43 +02:00
Noah Davis
b382bca34c Don't use highlightedTextColor for TabButtons
PC2 didn't do that and it doesn't look good with Breeze
2020-08-31 12:53:49 +00:00
Noah Davis
0f96187bfa Remove Layout.minimumWidth from Button and ToolButton
This fixes non-square buttons in plasma-pa.
2020-08-31 10:18:22 +00:00
Noah Davis
4980e4e985 Use the spacing property for the spacing between Button/ToolButton icons and labels 2020-08-31 10:18:22 +00:00
Noah Davis
7838a4ecc9 Add private/ButtonContent.qml for PC3 Buttons and ToolButtons
This allows Buttons and ToolButtons to share almost all of the same code, which prevents unnecessary inconsistencies.
2020-08-31 10:18:22 +00:00
Noah Davis
9e9136bddd Change PC3 Button and ToolButton implicitWidth and implicitHeight to account for inset values 2020-08-31 10:18:22 +00:00
Noah Davis
73865f7171 Add implicitWidth and implicitHeight to ButtonBackground
Remove unnecessary keyboardFocus property since visualFocus exists

Remove unnecessary parentControl property
2020-08-31 10:18:22 +00:00
Noah Davis
54069ee94c Remove minimum size test from PC3 Button test
Also add disabled buttons to the PC3 Button test

The minimum size test didn't make any sense. You don't normally set the implicitWidth of a button to Layout.minimumWidth in a Layout.
2020-08-31 10:18:22 +00:00
Noah Davis
34bed4571c Reduce toolbutton margins to 4px
This makes it so flat buttons can use 22px icons, but still be the same size as raised buttons
2020-08-31 10:18:22 +00:00
Carson Black
c24ebf1d12 Fix incorrect default for PlasmaExtras.ListItem
This fixes the mismatched default sectionDelegate compared to PlasmaComponents.ListItem,
where it was default false and this was default true.

BUG: 425769
2020-08-30 23:41:22 +00:00
David Redondo
8c37d1d225 Don't let the background become smaller than the svg
Otherwise the svg rendering results in broken looks.
BUG:424448
2020-08-25 15:11:17 +00:00
Niccolò Venerandi
e4ab700b70 ops 2020-08-24 19:57:15 +02:00
Niccolò Venerandi
60e029d9d2 Merge branch 'master' of https://invent.kde.org/frameworks/plasma-framework into work/plasmoidsCanIgnoreMargins 2020-08-24 19:56:20 +02:00
Friedrich W. H. Kossebau
3f8469acb1 Use Q_DECLARE_OPERATORS_FOR_FLAGS in same namespace as flags definition
Having the macro's definition of the operator| in the namespace of the
flags argument improves/unbreaks things for the argument-dependent
lookup of unqualified function names, e.g. when flags are combined in
calls of other methods, but there is some other operator| defined in the
namespace of the current code.

Given Q_DECLARE_OPERATORS_FOR_FLAGS creates inlined functions, this
should be a source and binary compatible change.

Qt did similar for Qt 5.12 in
https://codereview.qt-project.org/c/qt/qtbase/+/225348
2020-08-24 09:21:41 +00:00
Noah Davis
3509283d63 Make PC3 BusyIndicator visuals keep a 1:1 aspect ratio
Updated the tests so that you can see if the aspect ratio is correct.

Made an animated transition for when `control.running` is false.

Removed the code that updates the RotationAnimator when control.running changes since it didn't work.

Set padding to 0 (see comment).

BUG: 425504
2020-08-23 15:08:32 -04:00
Niccolò Venerandi
dcb26d979e ops 2020-08-22 16:56:05 +02:00