Commit Graph

3252 Commits

Author SHA1 Message Date
Marco Martin
2af3225c26 size.isEmpty() does the same and looks nicer, good catch sebas :)
svn path=/trunk/KDE/kdelibs/; revision=894919
2008-12-09 16:22:03 +00:00
Rob Scheepmaker
b321b2f033 Performance optimization: only change the icon if it's actually a different icon. Mainly affects uiserver widgets atm.
Oh, and warning--.


svn path=/trunk/KDE/kdelibs/; revision=894878
2008-12-09 14:04:33 +00:00
Marco Martin
e166600984 last commit was indeed correct but the whole thing still a bit wrong..
the other  problem was that cachePath() did take the wrong size, the size
of the whole svg vs the size of the element to be drawn (and that was my
bad, so we can share the misery now, aaron:)

CCBUG:177172

svn path=/trunk/KDE/kdelibs/; revision=894713
2008-12-09 09:03:12 +00:00
Marco Martin
ff8af18497 a size like QSize(10,0) is valid but will end up in a null pixmap, and
this thing did confuse the cache a lot
CCBUG: 177172
does this patch fixes it? will keep open a day to be really sure :)

svn path=/trunk/KDE/kdelibs/; revision=894591
2008-12-08 22:22:18 +00:00
Aaron J. Seigo
9edf9c2ac0 do the cheap check first
svn path=/trunk/KDE/kdelibs/; revision=894561
2008-12-08 21:31:13 +00:00
Aaron J. Seigo
7bc2bfd8da constBegin
svn path=/trunk/KDE/kdelibs/; revision=894558
2008-12-08 21:27:42 +00:00
Aaron J. Seigo
e328a0a6c1 build .. =/
svn path=/trunk/KDE/kdelibs/; revision=894557
2008-12-08 21:26:46 +00:00
Aaron J. Seigo
12eca1edaf use a const iterator; some ws fixes
svn path=/trunk/KDE/kdelibs/; revision=894551
2008-12-08 21:16:55 +00:00
Aaron J. Seigo
011832d5fb --compiler_warnings;
svn path=/trunk/KDE/kdelibs/; revision=894470
2008-12-08 18:05:17 +00:00
Aaron J. Seigo
e42452e847 * update the direction on location changes
* update the dialog, if it exists, when checking the border of the extender
BUG:177113

svn path=/trunk/KDE/kdelibs/; revision=894469
2008-12-08 18:03:23 +00:00
Marco Martin
1d7144e6f7 die hardcoded colors, die!
svn path=/trunk/KDE/kdelibs/; revision=894466
2008-12-08 17:51:53 +00:00
Aaron J. Seigo
dffbf7817c prevent possible crash
svn path=/trunk/KDE/kdelibs/; revision=894455
2008-12-08 17:32:57 +00:00
Aaron J. Seigo
2d6431cafa don't crash when a runner that doesn't exist is requested
BUGS:170989,177162

svn path=/trunk/KDE/kdelibs/; revision=894424
2008-12-08 15:59:05 +00:00
Script Kiddy
f40bc9cf36 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdelibs/; revision=894370
2008-12-08 13:44:23 +00:00
Marco Martin
1a4565f740 unset the cursor only on mouse release
BUG: 170347

svn path=/trunk/KDE/kdelibs/; revision=894074
2008-12-07 20:47:58 +00:00
Marco Martin
212a4238bd reposition the popup after saving, so won't jump always to the old size
svn path=/trunk/KDE/kdelibs/; revision=894071
2008-12-07 20:20:28 +00:00
Rob Scheepmaker
9116edc392 Use iconSize() function now that that function exists. This avoids having the margins in the dragger 2 pixels smaller then specified.
svn path=/trunk/KDE/kdelibs/; revision=894041
2008-12-07 18:28:26 +00:00
Rob Scheepmaker
7a90f822a5 Resize Plasma::Meter not to it's native size, since larger fonts will get cut off. Instead count the amount of label rows and multiply with the font height.
svn path=/trunk/KDE/kdelibs/; revision=893992
2008-12-07 16:45:49 +00:00
Marco Martin
becd2b631e some cleanups in the caching code
with that the systray background rendering problems seems somewhat less
frequent

svn path=/trunk/KDE/kdelibs/; revision=893751
2008-12-07 12:44:10 +00:00
Aaron J. Seigo
25b3937022 wow, that was massively broken!
svn path=/trunk/KDE/kdelibs/; revision=893519
2008-12-06 18:58:32 +00:00
Marco Martin
ac9356bd85 update the popup position right after creating the popup itself
BUG:177035

svn path=/trunk/KDE/kdelibs/; revision=893271
2008-12-06 12:15:49 +00:00
Marco Martin
ba43ebdd06 corrected sizing problem
animation jumps a bit less randomly
BUG: 176672

svn path=/trunk/KDE/kdelibs/; revision=893099
2008-12-05 22:48:58 +00:00
Marco Martin
b47c32869f use elements dimensions to resize the scrollbar
svn path=/trunk/KDE/kdelibs/; revision=893050
2008-12-05 21:04:33 +00:00
Marco Martin
2952fe3e5f rects cache and pixmap cache needs indeed ids a bit different due to the
fact that framesvgs are always at the "natural" size per se...
this should fix the systray breakage

svn path=/trunk/KDE/kdelibs/; revision=893029
2008-12-05 19:50:01 +00:00
Marco Martin
98b833977b correct some last toolbox annoyances...
svn path=/trunk/KDE/kdelibs/; revision=893011
2008-12-05 18:16:30 +00:00
Script Kiddy
5acc95a83b SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdelibs/; revision=892891
2008-12-05 12:58:22 +00:00
Rob Scheepmaker
5ba015fa56 Removed obsolete call to updateDialogPosition, and use this function in dialogSizeChanged() for consistent dialog position. This solves the problem of the dialog being moved twice when the size of the widget changes.
svn path=/trunk/KDE/kdelibs/; revision=892689
2008-12-04 23:57:47 +00:00
Marco Martin
8994cc5ad6 we have the cure cacheId() function, let's use it mmkay?
svn path=/trunk/KDE/kdelibs/; revision=892656
2008-12-04 20:40:46 +00:00
Marco Martin
e22429867b int with a frameSvg when it's not in a corner
svn path=/trunk/KDE/kdelibs/; revision=892649
2008-12-04 20:36:35 +00:00
Aaron J. Seigo
2207ff1dc5 make it possible to remove panels again
svn path=/trunk/KDE/kdelibs/; revision=892648
2008-12-04 20:34:04 +00:00
Aaron J. Seigo
e377d738ec base the name of the cache on the theme name so that different apps can share it (krunner, plasa, etc)
svn path=/trunk/KDE/kdelibs/; revision=892641
2008-12-04 20:13:50 +00:00
Fredrik Höglund
cc50a63ef6 flicker--
svn path=/trunk/KDE/kdelibs/; revision=892582
2008-12-04 17:03:00 +00:00
Alain Boyer
dd61c4ef02 My first kommit! ;)
Use the local rect cache when possible. This gives another performace boost to painting code.

svn path=/trunk/KDE/kdelibs/; revision=892539
2008-12-04 14:25:40 +00:00
Marco Martin
b596d894e5 keep remove action enabled on panels
svn path=/trunk/KDE/kdelibs/; revision=892472
2008-12-04 12:55:34 +00:00
Marco Martin
c64d38b551 waay more reliable toolbox->toolbar switching, killed the weird
d->needsToolbarBehaviour()

svn path=/trunk/KDE/kdelibs/; revision=892273
2008-12-03 22:44:16 +00:00
Marco Martin
85ef865213 disconnect d->containment, not containment :)
in some cases the view became without any active containment otherwise

svn path=/trunk/KDE/kdelibs/; revision=892260
2008-12-03 22:03:04 +00:00
Marco Martin
1c4f777dd4 hide and unhide the icon when its action visibility changes (no more
ghost lockers with zoomed out desktop:)

svn path=/trunk/KDE/kdelibs/; revision=892159
2008-12-03 17:53:13 +00:00
Marco Martin
b2d528c0d3 flush pending constraint events after adding a containment, this makes
the close buttons appear and relayout when resized

svn path=/trunk/KDE/kdelibs/; revision=892097
2008-12-03 14:31:59 +00:00
Aaron J. Seigo
5055bf7bf0 the margins should be constant; it's a grid.
svn path=/trunk/KDE/kdelibs/; revision=891718
2008-12-02 18:42:06 +00:00
Script Kiddy
54340e9701 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdelibs/; revision=891615
2008-12-02 13:38:31 +00:00
Beat Wolf
8eeb660cdd fixing typo. Resolves toolbox that is drawn outside screen
svn path=/trunk/KDE/kdelibs/; revision=891521
2008-12-02 12:44:39 +00:00
Aaron J. Seigo
f8acdb1861 apparently the documentation isn't right and you shouldn't delete the entries
to the report of the bug: please check that this fixes it for you whenever you can get an updated build (e.g. next build, or sooner if using svn); if not, please comment on the report and reopen it. thanks.

BUG:176661

svn path=/trunk/KDE/kdelibs/; revision=891424
2008-12-02 00:08:09 +00:00
Aaron J. Seigo
20260277d3 QSizeF lacks some niceties found in QSize
svn path=/trunk/KDE/kdelibs/; revision=891380
2008-12-01 21:40:13 +00:00
Aaron J. Seigo
613383b1ea clear the local cache on resize; prevent ever growing memory usage due to the cache and looking through our applet code people tend to resize rarely, and not between paints
svn path=/trunk/KDE/kdelibs/; revision=891373
2008-12-01 21:10:33 +00:00
Rob Scheepmaker
ab56a3a388 Couple of fixes:
* Close empty extender when clicking in it.
BUG:176545
* Saner size policy for Plasma::Meter. (the height should never be able to be smaller then svg's height because labels could otherwise overlap, actually, the whole current approach doesn't consider font size, I think we should think of a better approach for 4.3)
* Use the same spacer as used in the panel for extenders. I think we would want some svg themable shared spacer widget for 4.3, but at least this adds some consistency.


svn path=/trunk/KDE/kdelibs/; revision=891328
2008-12-01 18:30:42 +00:00
Aaron J. Seigo
f25e5b82ff provide a local rect cache in each Svg object to avoid going through the canonical but slower Theme cache more than once; makes a big difference for performance as these calls are made in painting hot paths
svn path=/trunk/KDE/kdelibs/; revision=891325
2008-12-01 18:07:20 +00:00
Jesse Lee Zamora
48cf523fc4 With the device notifier, the Plasma::Delegate would draw a gradient even when the
item text wasn't too long. This fixes that little issue.

too long

svn path=/trunk/KDE/kdelibs/; revision=891301
2008-12-01 16:31:47 +00:00
Marco Martin
6c7c11e934 exactly the same delayed cache insertion did for framesvg,
now the thing is really faster

svn path=/trunk/KDE/kdelibs/; revision=891275
2008-12-01 14:35:02 +00:00
Marco Martin
9fd8a3298d correctly position new activity when adding one
never show text on wider zoom level

svn path=/trunk/KDE/kdelibs/; revision=891258
2008-12-01 13:17:27 +00:00
Marco Martin
d9c14c87ba show the toolbox as an external solid-background toolbar under the
containment, don't show text on icons except add windgets and add
activity
show the remove activity button in the toolbox for non active ones

svn path=/trunk/KDE/kdelibs/; revision=891209
2008-12-01 12:40:08 +00:00