Norman Maurer
7d7b676eeb
[maven-release-plugin] prepare for next development iteration
2013-03-22 15:20:35 +01:00
Norman Maurer
60fc7dac4d
[maven-release-plugin] prepare release netty-4.0.0.CR1
2013-03-22 15:20:11 +01:00
Norman Maurer
4bd9c0195f
Add a handler that makes writing websocket clients much easier
2013-03-22 12:11:35 +01:00
Trustin Lee
d3327e7f46
Fix inspector warnings
2013-03-18 13:10:55 +09:00
ursa
ecaba68348
Fix bug in memory-based HTTP data content initialization with input stream, add test (port from branch 3).
...
- Fixes #1170
2013-03-18 13:05:40 +09:00
Trustin Lee
2a87950784
[maven-release-plugin] prepare for next development iteration
2013-03-16 18:41:36 +09:00
Trustin Lee
adfb29330b
[maven-release-plugin] prepare release netty-4.0.0.Beta3
2013-03-16 18:40:59 +09:00
Norman Maurer
d9c3f4bc05
[ #1159 ] Make sure we not produce an empty bytebuf on decodeLast(..)
2013-03-14 12:45:24 +01:00
Trustin Lee
6e0e38f09f
Fix test failures
2013-03-12 14:43:38 +09:00
Trustin Lee
c660002b4e
Add DecoderResult.UNFINISHED to represent the case where a decoder generated a message that was not decoded completely / Remove partial failure in DecoderResult which is not very useful but confusing
2013-03-12 13:04:53 +09:00
Norman Maurer
acde9a3f8e
Fix a NoSuchElementException when WebSocketClientHandshaker is used with HttpRequestEncoder. This time for real
2013-03-11 14:39:41 +01:00
Norman Maurer
978cf0d98a
Fix a NoSuchElementException when WebSocketClientHandshaker is used with HttpRequestEncoder
2013-03-11 13:54:03 +01:00
Norman Maurer
fd3f923b52
Allow to specify the used buffer type for ChannelInboundByteBufHandler and ChannelOutboundByteBufHandler by configuration. As default it tries to use a direct ByteBuf
2013-03-08 08:20:46 +01:00
Trustin Lee
a9a29bdf3f
Use I/O buffer whenever possible now that our direct buffers are as fast as heap buffers
2013-03-08 11:21:08 +09:00
Norman Maurer
6ac9b17ddd
Make WebSocket codec also work when HttpClientCodec and HttpServerCodec is used.
...
Also refactor the handshakers to share more code and make it easier to implement a new one and less error-prone
2013-03-08 08:46:47 +09:00
Trustin Lee
a8a7c4f576
Provide a way to implement an ChannelInbound/OutboundMessageHandler conveniently without extending an adapter class
...
- Add ChannelHandlerUtil and move the core logic of ChannelInbound/OutboundMessageHandler to ChannelHandlerUtil
- Add ChannelHandlerUtil.SingleInbound/OutboundMessageHandler and make ChannelInbound/OutboundMessageHandlerAdapter implement them. This is a backward incompatible change because it forces all handler methods to be public (was protected previously)
- Fixes : #1119
2013-03-05 17:27:53 +09:00
Justin Santa Barbara
6246825fda
[ #1100 ] Fix SPDY codec to work again in 4.x
2013-02-28 11:35:38 +01:00
Norman Maurer
b6038534cc
[ #1101 ] Fix NPE which accour when send a 100-continue response and using the HttpContentEncoder
2013-02-28 07:13:21 +01:00
Norman Maurer
977b6f3a28
[ #1101 ] Fix NPE which accour when send a 100-continue response and using the HttpContentDecoder
2013-02-28 07:06:39 +01:00
Trustin Lee
49aa907bd0
[maven-release-plugin] prepare for next development iteration
2013-02-26 16:55:07 -08:00
Trustin Lee
5026c2f359
[maven-release-plugin] prepare release netty-4.0.0.Beta2
2013-02-26 16:54:53 -08:00
Trustin Lee
671f9d48d4
Use ConcurrentHashMapV8 wherever possible
...
- Fixes #1052
2013-02-26 15:54:51 -08:00
Trustin Lee
f67441354a
Move logging classes from internal to internal.logging
...
.. because internal is crowded
2013-02-26 14:54:25 -08:00
Norman Maurer
eb2aa7f6d4
Cleanup
2013-02-26 08:01:18 +01:00
Norman Maurer
a03bd5105a
[##1064] Fix problem where the LastHttpContent was changed to HttpContent and so the end was never detected
2013-02-26 07:47:30 +01:00
Norman Maurer
30e7ab2f7d
[ #1089 ] Correctly offer FullHttpContent if it is used to construct HttpPostRequestDecoder
2013-02-26 07:33:04 +01:00
Trustin Lee
9e67cce932
Use BufUtil.retain() where possible
2013-02-21 13:58:13 -08:00
Norman Maurer
43ff36cef0
Cleanup
2013-02-21 19:31:05 +01:00
Norman Maurer
00310d96af
[ #1067 ] Fix bug which can cause IllegalBufferAccessException when using aggregator and deflater the same time
2013-02-21 06:48:53 +01:00
Atsuhiko Yamanaka
8fdf788cbd
[ #1012 ] Replace forked jzlib with official jzlib and add a test.
2013-02-20 12:49:05 +01:00
Trustin Lee
d68a04a879
[maven-release-plugin] prepare for next development iteration
2013-02-14 12:56:24 -08:00
Trustin Lee
59e638f8f5
[maven-release-plugin] prepare release netty-4.0.0.Beta1
2013-02-14 12:56:15 -08:00
Trustin Lee
1011227b88
Remove apiviz tags - we are focusing on user guide instead and putting diagrams there
2013-02-14 12:09:16 -08:00
Norman Maurer
54435a908f
Make internal class final and package private
2013-02-14 09:36:27 +01:00
Norman Maurer
5370573400
Change ReferenceCounted.retain* to return itself and so allow method chaining
2013-02-14 07:39:44 +01:00
Norman Maurer
fcba55329c
[ #1046 ] Make sure HttpContentEncoder calls ByteBuf.retain() if needed
2013-02-12 20:32:27 +01:00
Trustin Lee
b4f4b95739
Move io.netty.logging to io.netty.internal / Move Signal out of internal because we use it in Channel*MessageAdapters
2013-02-11 20:08:18 +09:00
Trustin Lee
a91c6596c4
Add TODO
2013-02-11 19:43:53 +09:00
Trustin Lee
a2e5cd94be
Prettify APIviz / Tighten visibility / Move subclasses to top level / Remove unused UnknownSocksMessage
2013-02-11 19:42:23 +09:00
Trustin Lee
bf0bfe9a69
Fix inspector warnings
2013-02-11 16:52:43 +09:00
Norman Maurer
0e47fb50e2
Tighten up visibility
2013-02-11 07:26:10 +01:00
Trustin Lee
4f6d05365a
Fix a race condition in reference counter implementation / Reference count never goes below 0
2013-02-10 14:22:14 +09:00
Trustin Lee
2f1a0b0593
Remove freeInbound/OutboundMessage(), replaced by ReferenceCounted.retain/release()
...
- Related: #1029
2013-02-10 13:31:31 +09:00
Trustin Lee
b9996908b1
Implement reference counting
...
- Related: #1029
- Replace Freeable with ReferenceCounted
- Add AbstractReferenceCounted
- Add AbstractReferenceCountedByteBuf
- Add AbstractDerivedByteBuf
- Add EmptyByteBuf
2013-02-10 13:10:09 +09:00
Trustin Lee
27190fcb7f
Fix a bug where HttpContentDecoder emits duplicate HttpMessage or raises NPE
2013-02-10 01:35:01 +09:00
Trustin Lee
2ac7983471
Do not trigger inboundBufferUpdated unnecessarily / Fix a bug in WebSocketServerProtocolHandlerTest / Fix a bug in forbiddenHttpRequestResponder()
2013-02-09 20:32:49 +09:00
Norman Maurer
42b21222dc
[ #1025 ] Allow to add extra headers to the websocket handshake response
2013-02-08 19:54:05 +01:00
Trustin Lee
ee189d1da7
Use finer grained type parameter in SPDY
2013-02-08 17:57:20 +09:00
Trustin Lee
82c46180c9
Tighten access modifier of encode/decode()
2013-02-08 17:37:16 +09:00
Trustin Lee
76eb40a4d2
Make ChannelOutboundMessageHandlerAdapter similar to ChannelInboundMessageHandlerAdapter
2013-02-08 17:07:01 +09:00
Trustin Lee
1640b1fea6
Automatically detect the message types in MessageToMessageCodec
2013-02-08 16:12:32 +09:00
Trustin Lee
fa1b49de98
More robust automatic messageType detection for ChannelInboundMessageHandlerAdapter and MessageToMessageDecoder
2013-02-08 15:45:17 +09:00
Trustin Lee
e5616c85c4
Automatic messageType detection for ChannelInboundMessageHandlerAdapter
2013-02-08 13:48:47 +09:00
Trustin Lee
d4742bbe16
Clean up abstract ChannelHandler impls / Remove ChannelHandlerContext.hasNext*()
...
- Rename ChannelHandlerAdapter to ChannelDuplexHandler
- Add ChannelHandlerAdapter that implements only ChannelHandler
- Rename CombinedChannelHandler to CombinedChannelDuplexHandler and
improve runtime validation
- Remove ChannelInbound/OutboundHandlerAdapter which are not useful
- Make ChannelOutboundByteHandlerAdapter similar to
ChannelInboundByteHandlerAdapter
- Make the tail and head handler of DefaultChannelPipeline accept both
bytes and messages. ChannelHandlerContext.hasNext*() were removed
because they always return true now.
- Removed various unnecessary null checks.
- Correct method/field names:
inboundBufferSuspended -> channelReadSuspended
2013-02-07 23:47:45 +09:00
Norman Maurer
582c6be456
[ #1023 ] WebSocketClientHandshaker00 now also work with non heap buffers
2013-02-07 14:21:11 +01:00
ursa
f09b85f4e7
Add test for HttpPostRequestDecoder: validate '\r' symbols in the end of binary stream are parsed correctly.
2013-02-06 20:21:56 +01:00
Norman Maurer
fd75615d7a
[ #870 ] Convert all modules into osgi bundles
2013-02-06 07:57:11 +01:00
ursa
992d431a95
Fix line-end detection for binary streams upload.
...
- Related: #1016
2013-02-06 11:54:05 +09:00
Trustin Lee
2ec932798f
Replace .readable() and .writable() to .isReadable() and .isWritable()
2013-01-31 18:24:33 +01:00
Trustin Lee
42c65cca3a
Make MessageBuf bounded
...
- Move common methods from ByteBuf to Buf
- Rename ensureWritableBytes() to ensureWritable()
- Rename readable() to isReadable()
- Rename writable() to isWritable()
- Add isReadable(int) and isWritable(int)
- Add AbstractMessageBuf
- Rewrite DefaultMessageBuf and QueueBackedMessageBuf
- based on Josh Bloch's public domain ArrayDeque impl
2013-01-31 18:11:06 +01:00
Norman Maurer
ec013bf2d3
[ #983 ] Force the user to implement an actual ChannelInboundHandler or ChannelOutboundHandler
...
For this ChannelInboundHandler* and ChannelOutboundHandler* was made package private
2013-01-31 15:50:27 +01:00
Courtney Robinson
2d9cc9f63b
Allow to specify the mode the encoder uses for form params. This allows it to be used with OAUTH
...
The OAuth 1 spec has small deviations from UrlEncoder.encode's output.
+ Percent encodes the parameters
+ Added tests to verify
+ See relevant OAuth section
http://oauth.net/core/1.0/#encoding_parameters
+ Detailed explanation http://hueniverse.com/oauth/guide/authentication/
2013-01-31 07:49:34 +01:00
Norman Maurer
97ea338bce
[ #971 ] Fix a bug where the HttpContentCompressor was try to start compressing on an empty response
2013-01-30 20:58:07 +01:00
Norman Maurer
cff2edf75d
Remove not used enum
2013-01-30 19:02:29 +01:00
Norman Maurer
3843cfd702
[SPDY] Factor out headers into extra class like we did in http and support method chaining where possible
2013-01-30 08:23:07 +01:00
Norman Maurer
238e03f75b
Add setters and getters back to Http Objects
...
* This is done because we noticed that the previous change limit the usage more then it gave us any benefit. Now it is possible
again to rewrite the url on the fly or reuse the objects when writing a proxy and so limit the GC pressure.
* Fixes also #979
2013-01-30 07:42:18 +01:00
Trustin Lee
c5ccaee506
Fix a bug in HttpPostRequestDecoder where character encoding is ignored when reading a line
...
- Fixed #992 (backported from 3)
- 9650cda163
- b38bde2d2b
2013-01-29 15:59:15 +09:00
Norman Maurer
d7bfd44e10
[ #982 ] [ #977 ] [ #858 ] Allow to transfer the content a ChannelHandlers inbound/outbound buffer on removal/replacement
...
This changes the behavior of the ChannelPipeline.remove(..) and ChannelPipeline.replace(..) methods in that way
that after invocation it is not possible anymore to access any data in the inbound or outbound buffer. This is
because it empty it now to prevent side-effects. If a user want to preserve the content and forward it to the
next handler in the pipeline it is adviced to use one of the new methods which where introduced.
- ChannelPipeline.removeAndForward(..)
- ChannelPipeline.replaceAndForward(..)
2013-01-28 10:25:38 +01:00
Norman Maurer
29bed32a89
[ #963 ] Fix invalid free-up of messages if they are only passed-throught in HttpContentEncoder and HttpContentDecoder
2013-01-21 10:41:23 +01:00
Norman Maurer
c1e827fd72
[ #942 ] Add an option to disable decoding of chunked transfer encoding in HttpObjectDecoder
2013-01-20 10:40:54 +01:00
Trustin Lee
b60e0b6a51
Modernize InternalLogger API and enable logging framework autodetection
...
- Borrow SLF4J API which is the best of the best
- InternalLoggerFactory now automatically detects the logging framework
using static class loading. It tries SLF4J, Log4J, and then falls back
to java.util.logging.
- Remove OsgiLogger because it is very likely that OSGi container
already provides a bridge for existing logging frameworks
- Remove JBossLogger because the latest JBossLogger implementation seems
to implement SLF4J binding
- Upgrade SLF4J to 1.7.2
- Remove tests for the untestable logging frameworks
- Remove TestAny
2013-01-19 20:50:52 +09:00
Norman Maurer
e8636050ca
[ #864 ] Switch to single decoding mode on the protocol upgrade to prevent races
2013-01-18 09:56:17 +01:00
Trustin Lee
cfa300f431
Fix APIviz panic
2013-01-18 14:12:35 +09:00
Norman Maurer
8a9e602a66
Prevent possible ClassCastException
2013-01-17 09:37:17 +01:00
Trustin Lee
4472fe9795
Remove 'get' prefix
2013-01-17 15:06:46 +09:00
Trustin Lee
eacc474cda
Remove 'get' prefix
2013-01-17 14:48:03 +09:00
Norman Maurer
dfbecb796c
[ #910 ] Make use of ByteBufHolder in SPDY, HTTP multipart and WebSockets to allow for buffer pooling
2013-01-17 06:34:52 +01:00
Jeff Pinner
a192cfdbf0
SPDY: fix improper use of SYNC_FLUSH in SpdyHeaderBlockZlibCompressor
2013-01-16 10:42:24 -08:00
Trustin Lee
e95d3de1ff
Fix a bug where HttpContents are freed too early
2013-01-17 00:50:43 +09:00
Trustin Lee
4ee11cd36f
Fix bad test name
2013-01-17 00:42:51 +09:00
Trustin Lee
3b79008eda
Change the WebSocket API to use HttpHeaders instead of Map<String, String> for custom headers / Cleanup
2013-01-17 00:33:40 +09:00
Trustin Lee
540bc99549
Take advantage of invocation chaining in HttpHeaders
2013-01-16 23:56:51 +09:00
Trustin Lee
34820511ff
Second HTTP overhaul
...
- Rename message types for clarity
- HttpMessage -> FullHttpMessage
- HttpHeader -> HttpMessage
- HttpRequest -> FullHttpRequest
- HttpResponse -> FulllHttpResponse
- HttpRequestHeader -> HttpRequest
- HttpResponseHeader -> HttpResponse
- HttpContent now extends ByteBufHolder; no more content() method
- Make HttpHeaders abstract, make its header access methods public, and
add DefaultHttpHeaders
- Header accessor methods in HttpMessage and LastHttpContent are
replaced with HttpMessage.headers() and
LastHttpContent.trailingHeaders(). Both methods return HttpHeaders.
- Remove setters wherever possible and remove 'get' prefix
- Instead of calling setContent(), a user can either specify the content
when constructing a message or write content into the buffer.
(e.g. m.content().writeBytes(...))
- Overall cleanup & fixes
2013-01-16 23:46:02 +09:00
Norman Maurer
b7de868003
[ #677 ] Overhaul HTTP codec
...
This commit tries to simplify the handling of Http easier and more consistent. This has a effect of many channges. Including:
- HttpMessage was renamed to HttpHeader and the setContent and getContent methods were removed
- HttpChunk was renamed to HttpContent
- HttpChunkTrailer was renamed to LastHttpContent
- HttpCodecUtil was merged into HttpHeaders
Now a "complete" Http message (request or response) contains of the following parts:
- HttpHeader (HttpRequestHeader or HttpResponseHeader)
- 0 - n HttpContent objects which contains parts of the content of the message
- 1 LastHttpContent which marks the end of the message and contains the remaining data of the content
I also changed the sematic of HttpResponse and HttpRequest, these now represent a "complete" message which contains the HttpHeader and the HttpLastContent, and so can be used to eeasily send requests. The HttpMessageAggregator was renamed to HttpObjectAggregator and produce HttpResponse / HttpRequest message.
2013-01-15 17:51:12 +01:00
Jeff Pinner
f75b6b142c
SPDY: fix regression in SpdyFrameDecoder.decodeHeaderBlock()
2013-01-14 10:58:03 -08:00
Trustin Lee
1354b4a1ac
SPDY: allow empty header values in SPDY/3
...
Ported from 3
2013-01-14 22:59:11 +09:00
Trustin Lee
57153079a5
Chrome requires the :version: header in SPDY_SESSION_PUSHED_SYN_STREAM frames otherwise it issues a HTTP_TRANSACTION_SPDY_SEND_REQUEST_HEADERS and a SPDY_STREAM_ERROR saying "HEADERS incomplete headers, but pending data frames."
...
Ported from 3
2013-01-14 22:37:05 +09:00
Trustin Lee
64ae8b6a37
Replace and merge DetectionUtil and DirectByteBufUtil into PlatformDependent and PlatformDependent0
...
PlatformDependent delegates the operations requires sun.misc.* to PlatformDependent0 to avoid runtime errors due to missing sun.misc.* classes.
2013-01-11 14:03:27 +09:00
Norman Maurer
ec5ad7b22c
[ #921 ] Fix NPE which can be thrown on bad-timing when using WebSocketClientHandshaker07
2013-01-10 12:40:27 +01:00
Trustin Lee
eb337ff5a7
Fix various inspection warnings
2013-01-10 15:23:58 +09:00
Trustin Lee
b5e6350bcb
Fix compiler warning
2013-01-10 13:55:15 +09:00
Norman Maurer
b742dcc209
[ #902 ] Remove usage of generics for output of Encoder/Decoder to make them more flexible again
2013-01-09 07:13:31 +01:00
Trustin Lee
dd6b7969b7
Give a handler more control over how its buffers' read bytes are discarded.
...
This pull request adds two new handler methods: discardInboundReadBytes(ctx) and discardOutboundReadBytes(ctx) to ChannelInboundByteHandler and ChannelOutboundByteHandler respectively. They are called between every inboundBufferUpdated() and flush() respectively. Their default implementation is to call discardSomeReadBytes() on their buffers and a user can override this behavior easily. For example, ReplayingDecoder.discardInboundReadBytes() looks like the following:
@Override
public void discardInboundReadBytes(ChannelHandlerContext ctx) throws Exception {
ByteBuf in = ctx.inboundByteBuffer();
final int oldReaderIndex = in.readerIndex();
super.discardInboundReadBytes(ctx);
final int newReaderIndex = in.readerIndex();
checkpoint -= oldReaderIndex - newReaderIndex;
}
If a handler, which has its own buffer index variable, extends ReplayingDecoder or ByteToMessageDecoder, the handler can also override discardInboundReadBytes() and adjust its index variable accordingly.
2013-01-09 13:34:09 +09:00
Trustin Lee
218afba1f2
Do not set 'Content-Encoding' if the target encoding is 'identity'
...
- Fixes #769
2013-01-01 15:13:35 +09:00
Norman Maurer
4e77bacdf7
[ #873 ] [ #868 ] Split ChannelFuture into ChannelFuture and ChannelPromise
2012-12-31 23:27:16 +09:00
Norman Maurer
852f546b5b
[ #846 ] Tighten up visibility
2012-12-25 18:54:55 +01:00
Norman Maurer
5bd3648b3d
[ #845 ] Enable PUT of files above 2GB
2012-12-24 21:52:04 +01:00
Norman Maurer
2ea45950f1
Javadoc fixes
2012-12-23 23:03:54 +01:00
Veebs
92f1a81f47
#751 - Added support for legacy websocket v7 in order to pass SocksJS tests
2012-12-19 12:35:56 +01:00
Trustin Lee
78ccfeedf9
Save memory copy
2012-12-19 18:36:31 +09:00
Trustin Lee
937c0481e0
Do not use slice() to get the content of HTTP msg
...
- Fixes #794
2012-12-19 18:28:55 +09:00
Trustin Lee
42d466c97f
Remove cruft
2012-12-18 15:21:26 +09:00
Trustin Lee
310a87a51d
Fix #814 - Prevent IllegalBufferAccessException on write() and flush()
...
- Also fixed a incorrect port of SpdySessionHandler
- Previously, it closed the connection too early when sending a GOAWAY frame
- After this fix, SpdySessionHandlerTest now passes again without the previous fix
2012-12-18 04:53:37 +09:00
Trustin Lee
e59ac8e79b
Do not call inbound event methods directly
...
- Fixes #831
This commit ensures the following events are never triggered as a direct
invocation if they are triggered via ChannelPipeline.fire*():
- channelInactive
- channelUnregistered
- exceptionCaught
This commit also fixes the following issues surfaced by this fix:
- Embedded channel implementations run scheduled tasks too early
- SpdySessionHandlerTest tries to generate inbound data even after the
channel is closed.
- AioSocketChannel enters into an infinite loop on I/O error.
2012-12-18 03:04:26 +09:00
Trustin Lee
3f9441f4c1
Add missing free() on SpdySessionHandler buffers
2012-12-17 19:29:36 +09:00
Trustin Lee
def12a171c
Rename ChannelBuf to Buf and ChannelBufType to BufType
...
- Fixes #825
2012-12-17 17:43:45 +09:00
Trustin Lee
eb23c9d27c
Add missing 'operation(args, future)' for 'operation(args)'
...
- Fixes #818
- Fix inspector warnings
2012-12-14 19:42:58 +09:00
Trustin Lee
5a4a59406b
Merge ByteBuf.hasNioBuffer() and hasNioBuffers()
...
- Fixes #797
2012-12-14 12:20:33 +09:00
Trustin Lee
ad10518fca
Fix the incorrect snapshot version number
2012-12-13 22:49:31 +09:00
Veebs
0c5fd38eb6
#722 - Make WebSocketClientHandshakerFactory a static utility class
2012-12-13 07:34:05 +01:00
Veebs
2704efc056
Added documentation to websocket classes.
2012-12-13 07:13:46 +01:00
Norman Maurer
312810d415
[ #795 ] Fix WebSocketClientHandshaker13 and WebSocketClientHandshaker08 finishHandshake() method.
2012-12-07 20:14:11 +01:00
Norman Maurer
85c570505b
[maven-release-plugin] prepare for next development iteration
2012-12-03 20:34:05 +01:00
Norman Maurer
17d77ed160
[maven-release-plugin] prepare release netty-4.0.0.Alpha8
2012-12-03 20:33:49 +01:00
Trustin Lee
33c0c89fef
Remove unnecessary empty lines
2012-12-03 19:58:13 +09:00
Norman Maurer
717bde05e2
[786] Fix possible corruption of first WebSocketFrame caused by WebSocketServerHandshaker*
2012-12-02 19:55:45 +01:00
Trustin Lee
81e2db10fa
ByteBufAllocator API w/ ByteBuf perf improvements
...
This commit introduces a new API for ByteBuf allocation which fixes
issue #643 along with refactoring of ByteBuf for simplicity and better
performance. (see #62 )
A user can configure the ByteBufAllocator of a Channel via
ChannelOption.ALLOCATOR or ChannelConfig.get/setAllocator(). The
default allocator is currently UnpooledByteBufAllocator.HEAP_BY_DEFAULT.
To allocate a buffer, do not use Unpooled anymore. do the following:
ctx.alloc().buffer(...); // allocator chooses the buffer type.
ctx.alloc().heapBuffer(...);
ctx.alloc().directBuffer(...);
To deallocate a buffer, use the unsafe free() operation:
((UnsafeByteBuf) buf).free();
The following is the list of the relevant changes:
- Add ChannelInboundHandler.freeInboundBuffer() and
ChannelOutboundHandler.freeOutboundBuffer() to let a user free the
buffer he or she allocated. ChannelHandler adapter classes implement
is already, so most users won't need to call free() by themselves.
freeIn/OutboundBuffer() methods are invoked when a Channel is closed
and deregistered.
- All ByteBuf by contract must implement UnsafeByteBuf. To access an
unsafe operation: ((UnsafeByteBuf) buf).internalNioBuffer()
- Replace WrappedByteBuf and ByteBuf.Unsafe with UnsafeByteBuf to
simplify overall class hierarchy and to avoid unnecesary instantiation
of Unsafe instances on an unsafe operation.
- Remove buffer reference counting which is confusing
- Instantiate SwappedByteBuf lazily to avoid instantiation cost
- Rename ChannelFutureFactory to ChannelPropertyAccess and move common
methods between Channel and ChannelHandlerContext there. Also made it
package-private to hide it from a user.
- Remove unused unsafe operations such as newBuffer()
- Add DetectionUtil.canFreeDirectBuffer() so that an allocator decides
which buffer type to use safely
2012-11-22 15:10:59 +09:00
Norman Maurer
2adebc4c54
[ #755 ] SPDY: fix header block values truncation in decompression
2012-11-20 20:09:59 +01:00
Mike Heath
ff14feeb54
The handshake handler should not handle the exception and simply close the socket. The exception should be propagated to the WebSocketServerProtocolHandler to send the appropriate response and then close the socket.
2012-11-20 10:00:28 +01:00
dantran
4107b08f29
Only generate OSGi manifest only at all-in-on sub module to reduce the complexity to the build
2012-11-19 06:27:18 +01:00
Jeff Pinner
ef26ffe9d8
SPDY: remove deprecated methods
2012-11-17 19:30:42 +01:00
Jeff Pinner
97d07253e2
SPDY: fixed session status (internal error misdocumented)
2012-11-17 19:30:42 +01:00
Norman Maurer
d28eca7138
[ #740 ] Fix WebSocketClientHandshaker00.finishHandshake() validations
2012-11-15 13:06:48 +01:00
Norman Maurer
46d713970b
[ #737 ] WebSocketClientHandshaker00 should set Content-Length header do workaround problem with proxy
2012-11-14 10:08:44 +01:00
Norman Maurer
3b729848dc
[ #735 ] Improve the notification of the handshake future
2012-11-13 20:05:54 +01:00
Norman Maurer
efaa5c2ff5
[ #735 ] Make sure the handshake ChannelFuture is notified after the right encoder is present in the ChannelPipeline
2012-11-13 09:26:32 +01:00
Norman Maurer
2d5028bfd6
[ #729 ] Correctly handle urls with empty abs_path in it when issue the websocket handshake
2012-11-12 15:29:02 +01:00
dantran
105f952f5d
Clean up maven-bungle-plugin warnings
2012-11-12 11:42:42 +01:00
dantran
e236f5b77d
[ #154 ] [ #727 ] Use maven-plugin-plugin to generate OSGi manifest
2012-11-12 09:15:36 +01:00
Trustin Lee
9ac522382a
Fix visibility warnings from the inspector.
2012-11-12 14:03:43 +09:00
Trustin Lee
a05064d3eb
Fix more inspection warnings + compilation errors
2012-11-12 13:25:00 +09:00
Trustin Lee
36c8eb02e8
Fix parameter namings + some more
2012-11-12 12:59:37 +09:00
Trustin Lee
6f2840193a
Fix inspection warnings related with JUnit usage
2012-11-12 12:45:06 +09:00
Trustin Lee
aedf8790c3
Fix various Javadoc issues / Do not use argN parameter names
2012-11-12 12:26:19 +09:00
Trustin Lee
ea4a0e3535
Prefer {@code ...} to <code>...</code> / Fix deprecation warnings
2012-11-12 11:51:23 +09:00
Trustin Lee
15642f2cd8
Do not call static methods via instances
2012-11-12 11:23:06 +09:00
Trustin Lee
9746bb2036
Make a member field final wherever possible
2012-11-12 09:43:55 +09:00
Trustin Lee
4dce19b814
Replace a variable with a constant wherever possible
2012-11-12 09:43:14 +09:00
Trustin Lee
aa7cd691df
Remove redundant 'else' branches.
2012-11-12 09:31:40 +09:00
Trustin Lee
91a61d7f43
Remove unnecessary qualifiers
2012-11-12 09:11:48 +09:00
Trustin Lee
61d872d6e2
Suppress false-positive inspection warnings /
2012-11-12 09:05:16 +09:00
Trustin Lee
a07fb94fe7
Prefer "str".equals(var) to var.equals("str") / Add proper null checks
2012-11-12 08:59:54 +09:00
Trustin Lee
b4f796c5e3
Use 'x' over "x" wherever possible / String.equals("") -> isEmpty()
2012-11-10 08:03:52 +09:00
Trustin Lee
05c416b674
Add 'static' modifier to the methods that don't need to be member methods
2012-11-10 07:54:33 +09:00
Trustin Lee
5a4b2ec07e
Replace keySet() + unnecessary map lookup with entrySet()
2012-11-10 07:36:42 +09:00
Trustin Lee
f77f13faf0
Make classes static wherever possible
2012-11-10 07:32:53 +09:00
Trustin Lee
9f2c1c4774
Use foreach loop wherever possible / Prefer String.contains() to indexOf() >= 0 / Prefer StringUtil.split() to String.split()
2012-11-10 07:24:54 +09:00
Trustin Lee
3f4b3314cc
DefaultHttpDataFactory.MINSIZE must be final
2012-11-10 07:11:31 +09:00
Trustin Lee
4e0f455e69
Remove methods overridden but identical with the super implementation / Make constructors of abstract classes protected rather than non-sense public
...
AbstractWrappedByteBuf.capacity(int) should raise a UnsupportedOperationException rather than ReadOnlyBufferException.
2012-11-10 07:10:30 +09:00
Trustin Lee
d6a0fe54fd
Remove unnecessary throws clauses for unchecked exceptions
2012-11-10 07:07:37 +09:00
Trustin Lee
0d0eb0abfb
Remove unused imports
2012-11-10 07:05:18 +09:00
Trustin Lee
23883d25ee
Remove various unnecessary qualifiers
2012-11-10 07:03:07 +09:00
Norman Maurer
211b4059b1
[ #719 ] Handle http requests without an absolute path the right way when encoding them, which is adding / to it
2012-11-09 20:09:07 +01:00
Trustin Lee
8ad50a3e9c
Remove recundant type casting
2012-11-10 02:13:15 +09:00
Trustin Lee
27dc582e2b
Fix a regression in HttpMessageDecoder due to a mistake during yak shaving
2012-11-10 01:55:33 +09:00
Trustin Lee
b8f5ef0423
Remove unnecessary null check before equals()
2012-11-10 01:34:39 +09:00
Trustin Lee
58ba0de659
Remove unnecessarily qualified static access
2012-11-10 01:32:21 +09:00
Trustin Lee
bbcb035246
Prefer isEmpty() over size() == 0 or length() == 0
2012-11-10 01:24:04 +09:00
Trustin Lee
957154c005
Remove redundant no-arg constructors
2012-11-10 01:08:18 +09:00
Trustin Lee
3d364c7f75
Enum should not have a non-final value
2012-11-10 00:53:37 +09:00
Trustin Lee
e21dc5925d
Replace dynamic regular expressions with precompiled Patterns or new StringUtil.split()
2012-11-10 00:41:22 +09:00
Trustin Lee
8842f8ef90
Add missing @Override annotation
2012-11-09 17:34:34 +09:00
Trustin Lee
2ab38d8685
Remove pointless bitwise expressions
2012-11-09 17:26:11 +09:00
Trustin Lee
994a8db8fc
Fix overly-strong type casts
2012-11-09 17:14:59 +09:00
Norman Maurer
90c0481ecf
[ #712 ] Fix parsing dates in the past bug in CookieDecoder
2012-11-08 09:38:32 +01:00
Norman Maurer
313f777491
[maven-release-plugin] prepare for next development iteration
2012-11-05 23:08:39 +01:00
Norman Maurer
57da8222a4
[maven-release-plugin] prepare release netty-4.0.0.Alpha7
2012-11-05 23:08:28 +01:00
Veebs
36ac52a4bd
Port http multipart package. See #709
2012-11-04 13:59:50 +01:00
Norman Maurer
0526e1cb06
[ #706 ] Fix SpdyHttpResponseStreamIdHandler which was ported incorrectly
2012-11-02 19:50:41 +01:00
Norman Maurer
87ba8cb4b0
[ #705 ] Fix SpdyOrHttpChooser
2012-11-02 17:58:19 +01:00
Jeff Pinner
be6ddb74aa
HTTP method should be case sensitive (RFC-2616 Sec. 5.1.1)
2012-11-01 22:52:23 -07:00
Cruz Julian Bishop
93d0226c03
Small checkstyle fixes
...
Netty can build again, now.
Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
2012-10-30 21:57:26 +10:00
Norman Maurer
4696fcde1f
[ #691 ] Correctly handle SpdyRstStreamFrame
2012-10-30 08:48:09 +01:00
Norman Maurer
e726ff63d9
Cleanup
2012-10-29 20:21:38 +01:00
Norman Maurer
87cc67306f
[maven-release-plugin] prepare for next development iteration
2012-10-28 18:41:25 +01:00
Norman Maurer
7315490fca
[maven-release-plugin] prepare release netty-4.0.0.Alpha6
2012-10-28 18:41:17 +01:00
Norman Maurer
afc687436a
Revert "[maven-release-plugin] prepare release netty-4.0.0.Alpha6"
...
This reverts commit 95de4db0f1
.
2012-10-28 18:36:15 +01:00
Norman Maurer
16eb4ec713
Revert "[maven-release-plugin] prepare for next development iteration"
...
This reverts commit e3e0776c20
.
2012-10-28 18:35:47 +01:00
Norman Maurer
e3e0776c20
[maven-release-plugin] prepare for next development iteration
2012-10-28 13:06:07 +01:00
Norman Maurer
95de4db0f1
[maven-release-plugin] prepare release netty-4.0.0.Alpha6
2012-10-28 13:05:59 +01:00
Trustin Lee
a6c4f651a7
[ #661 ] WebSocketClientHandshaker is broken.
...
- Remove HttpRequestEncoder after handshaking is complete
- Fix a bug in the WebSocket client example where it sends a frame even before handshake is complete
2012-10-16 14:40:39 -07:00
Norman Maurer
7eef61580e
No need to use a concurrent Queue with out new thread-model. See #626
2012-10-02 20:16:35 +02:00
Norman Maurer
09d9f46e58
Merge pull request #630 from ngocdaothanh/master
...
Add CORS headers
2012-10-01 21:49:38 -07:00
Norman Maurer
59cd054fe3
Merge SpdyOrHttpChooser and SpdyHttpResponseStreamIdHandler into master. See #626
2012-09-30 21:18:54 +02:00
Ngoc Dao
7751daf2a4
Add ACCESS_CONTROL_EXPOSE_HEADERS
2012-09-28 19:18:21 +09:00
Trustin Lee
820af50b63
[maven-release-plugin] prepare for next development iteration
2012-09-28 17:57:40 +09:00
Trustin Lee
595e1067c7
[maven-release-plugin] prepare release netty-4.0.0.Alpha5
2012-09-28 17:57:04 +09:00
Ngoc Dao
f5e94d27e0
Add CORS headers
...
http://en.wikipedia.org/wiki/Cross-origin_resource_sharing
https://developer.mozilla.org/en-US/docs/HTTP_access_control
2012-09-28 17:19:50 +09:00
Trustin Lee
94838ee274
[ #441 ] Provide a better way to handle decoder failures
...
* Rename isPartial() to isPartialFailure()
* Add isCompleteFailure() and isFailure()
2012-09-28 15:46:17 +09:00
Trustin Lee
623956b838
[ #441 ] Provide a better way to handle decoder failures
...
* Make HttpChunkAggregator handle DecoderResult properly
2012-09-28 15:26:38 +09:00
Trustin Lee
9155f58c64
Rename get/setDecodeResult() to get/setDecoderResult()
2012-09-28 15:20:02 +09:00
Trustin Lee
bf808b3486
Rename DecodeResult to DecoderResult
2012-09-28 15:19:08 +09:00
Trustin Lee
41e0ef2e9a
[ #441 ] Provide a better way to handle decoder failures
...
* Update toString() of all HttpObject implementations
* HttpMessageDecoder does not raise an exception but sets decoderResult property of the decoded message.
* HttpMessageDecoder discards inbound traffic once decoding fails, by adding a new state called BAD_MESSAGE.
* Add a test case that tests this behavior.
2012-09-28 15:16:29 +09:00
Trustin Lee
b923d0c51f
Use supertype HttpObject instead of HttpMessage + HttpChunk where possible
2012-09-28 14:00:07 +09:00
Trustin Lee
adebda1560
[ #441 ] Provide a better way to handle decoder failures
...
* Add DecodeResult that represents the result of decoding a message
* Add HttpObject which HttpMessage and HttpChunk extend.
** HttpObject has a property 'decodeResult'
2012-09-28 13:48:17 +09:00
Trustin Lee
2ecf26c8eb
Fix #525 Add CORS preflight headers to HttpHeaders.Names
2012-09-27 19:16:02 +09:00
Trustin Lee
a156f67804
[ #624 ] Add varargs constructor to MessageToByteEncoder, MessageToMessage(Encoder|Decoder|Codec) to implement default isEncodable/isDecodable()
...
.. and modify all their subtypes to take advantage of this improvement.
2012-09-23 17:01:31 +09:00
norman
3295145e88
[maven-release-plugin] prepare for next development iteration
2012-09-13 10:40:52 +02:00
norman
42685759de
[maven-release-plugin] prepare release netty-4.0.0.Alpha4
2012-09-13 10:40:44 +02:00
norman
8ab1ef1432
Fix checkstyle
2012-09-10 12:10:24 +02:00
norman
0233a3dd63
Close the channel after the response was written to the client on a WebSocketHandshakeException. See #587
2012-09-10 07:22:35 +02:00
norman
6c2053bae5
Check if WebSocketServerProtocolHandshakeHandler is already in the pipeline before adding it. See #587
2012-09-10 07:18:26 +02:00
norman
6e39192462
Rename WebSocketServerHandshakeHandler to WebSocketServerProtocolHnadshakeHandler and also make it public. See #587
2012-09-10 07:15:59 +02:00
Norman Maurer
4353aa6794
Use Secure websockets if SslHandler is present in the ChannelPipeline. See #587
2012-09-09 19:48:53 +02:00
Norman Maurer
bd557a6330
Remove not necessary try / catch block. See #587
2012-09-09 19:35:56 +02:00
Jeff Smick
416c026efe
Upgrade client connection after completed response
2012-09-09 08:54:46 -07:00
Daniel Bevenius
150e8b4105
WebSocket enhancements
...
- Refactoring and adding suggestions from Norman and Vibul.
2012-09-09 08:30:40 +02:00
Norman Maurer
c6436ad470
Also move the replacement of the decoder to the ChannelFutureListener for the websocket upgrade. See #586
2012-09-09 08:21:32 +02:00
Jeff Smick
90d15c4627
Upgrade connection after completed response
...
Channel handlers above the HttpEncoder may delay the repsonse being
written to the socket. We need to wait for the response to complete
before upgrading the pipeline.
2012-09-08 20:54:43 -07:00
Trustin Lee
f2538a996d
[maven-release-plugin] prepare for next development iteration
2012-08-30 16:47:52 +09:00
Trustin Lee
628c5598b3
[maven-release-plugin] prepare release netty-4.0.0.Alpha3
2012-08-30 16:46:58 +09:00
Trustin Lee
73720c422d
[maven-release-plugin] prepare for next development iteration
2012-08-21 15:41:04 +09:00
Trustin Lee
68bef8cb99
[maven-release-plugin] prepare release netty-4.0.0.Alpha2
2012-08-21 15:40:45 +09:00
Trustin Lee
0a43350c66
[maven-release-plugin] prepare for next development iteration
2012-08-21 14:41:45 +09:00
Trustin Lee
56211fee59
[maven-release-plugin] prepare release netty-4.0.0.Alpha2
2012-08-21 14:39:59 +09:00
Trustin Lee
a0e34fd93a
[maven-release-plugin] prepare for next development iteration
2012-08-21 14:13:38 +09:00
Trustin Lee
72ccf65093
[maven-release-plugin] prepare release netty-4.0.0.Alpha2
2012-08-21 14:13:17 +09:00
Trustin Lee
a43f686d64
[ #527 ] Add Javadoc for HttpTransferEncoding
2012-08-21 14:05:04 +09:00
Trustin Lee
ec2b29f0b6
[ #539 ] Potential direct memory leak in HttpContentEn/Decoder
2012-08-20 13:38:14 +09:00
Trustin Lee
10f26f3205
[ #539 ] Potential direct memory leak in HttpContentEn/Decoder
2012-08-20 12:18:39 +09:00
Trustin Lee
7f3f792017
Fix a bug where CookieDecoder sets the default maxAge to -1
...
.. which should be Long.MIN_VALUE
2012-08-20 12:05:47 +09:00
Trustin Lee
b7ac3edf02
Add static modifier where static member is just enough.
2012-08-19 19:12:32 +09:00
Trustin Lee
602f976e41
[ #527 ] Add a new property to HttpMessage to help clarify its transfer encoding
...
- Add an enum: HttpTransferEncoding
- consists of SINGLE, STREAMED, and CHUNKED
- Add HttpMessage.transferEncoding
- replaces is/setChunked()
2012-08-19 19:06:47 +09:00
Norman Maurer
c22b559dfa
Set maxAge to Integer.MIN_VALUE by default. See #534
2012-08-19 11:55:15 +03:00
Norman Maurer
e80abf0b39
Update codec-http/src/main/java/io/netty/handler/codec/http/DefaultCookie.java
...
Allow to set a negative value for maxAge of DefaultCookie. See #533
2012-08-19 11:48:51 +03:00
Trustin Lee
0a99a33540
Use String.getBytes(Charset) wherever possible
2012-08-17 11:43:59 +09:00
Trustin Lee
de37d75871
[ #521 ] Encode URI using UTF-8 charset
...
- Forwardport @jpinner's pull request #522
- Use Charset instead of charset name
2012-08-17 11:39:36 +09:00
Trustin Lee
00d6010916
[ #494 ] Automatically adding chunked encoding header breaks streaming
...
Add a missing statement dropped while forwardporting
2012-08-17 11:34:35 +09:00
Trustin Lee
e530ccaeb8
Fix typo
2012-08-17 11:31:40 +09:00
Trustin Lee
0baf359202
[ #494 ] Automatically adding chunked encoding header breaks streaming
...
Forwardport @jamestyrrell's pull request
2012-08-17 11:30:08 +09:00
Jeff Pinner
d3d52edb31
SPDY: introduce SpdyControlFrame tag interface
2012-08-14 18:00:39 -07:00
Jeff Pinner
a0d9bed8f9
SPDY: remove deprecated data compressed flag
2012-08-14 17:58:22 -07:00
norman
ba1c7c5c55
Replace usage of QueueFactory with ConcurrentLinkedQueue and LinkedBlockingQueue. See #477
2012-07-30 08:01:46 +02:00
norman
bdde5a20f6
Allow to set Expires attribute
...
to a date in theast. See #479
2012-07-30 07:44:53 +02:00
Trustin Lee
8d813b127c
Replace free() with reference counting / Fix SlicedByteBuf.unsafe()
...
- based on @normanmaurer's feed back
- Added Unpooled.compositeBuffer(int)
2012-07-20 12:33:17 +09:00
Trustin Lee
5a613f379e
Make ByteBuf dynamic / Introduce an interface for composite buffers
...
- Replace ByteBufferBackedByteBuf with DirectByteBuf
- Make DirectByteBuf and HeapByteBuf dynamic
- Remove DynamicByteBuf
- Replace Unpooled.dynamicBuffer() with Unpooled.buffer() and
directBuffer()
- Remove ByteBufFactory (will be replaced with ByteBufPool later)
- Add ByteBuf.Unsafe (might change in the future)
2012-07-19 20:25:47 +09:00
Trustin Lee
250b40ec3b
Fix typo in test samples
2012-07-19 20:25:47 +09:00
Frédéric Brégier
e36c4c77bf
fix header to out
2012-07-18 11:50:28 +03:00
Frédéric Brégier
56a72c6456
writesBytes as in V3 instead of writeInt (RFC says 0 to 4 bytes)
2012-07-18 11:46:56 +03:00
Frédéric Brégier
92334b919e
Fix for issue #456 related to payload using 2 differents RANDOM while only one should be used
2012-07-18 11:43:36 +03:00
Trustin Lee
d801459cb8
[maven-release-plugin] prepare for next development iteration
2012-07-10 23:11:33 +09:00
Trustin Lee
527f2f6c6e
[maven-release-plugin] prepare release netty-4.0.0.Alpha1
2012-07-10 23:10:48 +09:00
Trustin Lee
e157ea1a66
Allow a user use any type as a ReplayingDecoder state / AIO cleanup
...
- Removed VoidEnum because a user can now specify Void instead
- AIO: Prefer discardReadBytes to clear
- AIO: Fixed a potential bug where notifyFlushFutures() is not called
if flush() was requested with no outbound data
2012-07-09 20:40:43 +09:00
Trustin Lee
9af7512c35
Use String.CASE_INSENSITIVE_ORDER instead of custom Comparator
2012-07-07 13:30:28 +09:00
norman
a7a4081e70
Fix checkstyle
2012-07-04 15:27:10 +02:00
norman
1784283d29
Correctly format cookies. This fix some bug which lead to expiring of cookies to not work. See #426
2012-07-04 15:20:47 +02:00
norman
61a7c78a53
Port fix for #433
2012-07-04 15:14:05 +02:00
norman
ac4dacd84f
Minimize byte copies by using a CompositeByteBuf to concat the chunks. See #413
2012-07-03 10:37:11 +02:00
Norman Maurer
c35f90f920
Port enhancement to reduce memory copy if possible. See #412
2012-06-29 13:26:13 +02:00
Norman Maurer
cd95dc5924
Merge pull request #422 from Massive-Dynamics/http-doc
...
Even more documentation changes (mainly) - HTTP
2012-06-29 02:55:20 -07:00
Cruz Julian Bishop
3792693468
Changed "Gets the" to "Returns the" - Requested by @trustin
2012-06-29 19:25:31 +10:00
Cruz Julian Bishop
f3fff2d3e8
Documentation redone for Cookie
2012-06-29 18:59:12 +10:00
Cruz Julian Bishop
26ed1a9972
Documentation and slight internal refactoring of HttpCodecUtil
2012-06-29 17:03:47 +10:00
Norman Maurer
d0c8c10681
Merge pull request #420 from Massive-Dynamics/fix-failed-javadoc
...
Fixes a bit of javadoc that was broken by a failed merge
2012-06-28 23:51:05 -07:00
Cruz Julian Bishop
4d5e4c3433
Make HttpResponse's javadoc a bit easier to read
2012-06-29 16:39:39 +10:00
Cruz Julian Bishop
a818cad45a
Make HttpRequest's documentation easier to read
2012-06-29 16:37:40 +10:00
Cruz Julian Bishop
59bb92171b
Made the documentation in HttpMessage a bit easier to understand
2012-06-29 16:33:14 +10:00
Cruz Julian Bishop
9f9b36f579
Redid documentation for WebSocketUtil
2012-06-29 15:12:59 +10:00
Cruz Julian Bishop
be57cf3b51
Fixes a bit of javadoc that was broken by a failed merge
2012-06-29 15:03:41 +10:00
Norman Maurer
2610a94de9
Fix SpdyHttpHeaders.setScheme setting the wrong header. See #417
2012-06-28 13:36:21 +02:00
Trustin Lee
90d9febbc0
Add more cookie decoding test case
2012-06-27 12:41:37 +09:00
Trustin Lee
a5d35f89d2
Add missing license headers
2012-06-26 17:33:05 +09:00
Trustin Lee
3b945bca78
Remove a method of no use
2012-06-26 05:30:07 +09:00
Trustin Lee
6d2f6d697d
Make CookieEncoder and CookieDecoder stateless
...
- Also: CookieEncoder is split into ServerCookieEncoder and
ClientCookieEncoder
2012-06-26 05:26:54 +09:00
Trustin Lee
7b2992a95a
Fix #218 : CookieDecoder.decode() throws StackOverflowError
...
- Rewrote key-value decoder not using a regular expression
2012-06-24 18:07:47 +09:00
Trustin Lee
ee8091f6fb
Fix #397 : Allow all cookie names that conform to the RFC
...
- Lenient flag is not needed anymore
2012-06-24 14:17:13 +09:00
Trustin Lee
0eb7a42c69
Fix test failures
2012-06-24 13:42:05 +09:00
Trustin Lee
a6e3d7d0ca
Fix #405 : CookieEncoder should refuse to encode more than one cookie
...
.. if on server mode
2012-06-24 12:59:44 +09:00
Trustin Lee
9ec51d01d6
Add ChannelMetadata and remove unnecessary disconnect() impls
...
- Add Channel.metadata() and remove Channel.bufferType()
- DefaultPipeline automatically redirects disconnect() request to
close() if the channel has no disconnect operation
- Remove unnecessary disconnect() implementations
2012-06-19 10:39:30 +09:00
Trustin Lee
1f69e664fb
Forward-port JDK ZlibEncoder patch ( #404 )
...
- Rename ZlibEncoder/Decoder to JZlibEncoder/Decoder
- Define a new ZlibEncoder/Decoder class
- Add JdkZlibEncoder
- All JZlib* and JdkZlib* extends ZlibEncoder/Decoder
- Add ZlibCodecFactory and use it everywhere
2012-06-19 09:54:25 +09:00
Trustin Lee
91fe9f4b38
serverID -> serverId ( #393 Ensure all fields follow naming convention)
2012-06-12 21:20:27 +09:00
Trustin Lee
a35aeb8cd9
StreamID -> StreamId ( #393 Ensure all fields follow naming convention)
2012-06-12 21:06:45 +09:00
Trustin Lee
9bf0ad8329
ID -> Id ( #393 Ensure all fields follow our naming convention)
2012-06-12 20:29:06 +09:00
Trustin Lee
60de50d89e
ID -> Id ( #393 Ensure all fields follow our naming convention)
2012-06-12 20:25:21 +09:00
Trustin Lee
154198a385
ID -> Id ( #393 Ensure all fields follow our naming convention)
2012-06-12 20:20:24 +09:00
Trustin Lee
676b81a4cd
getPersist(ed) -> isPersist(ed) ( #393 )
2012-06-12 20:05:12 +09:00
Trustin Lee
fdb66b6294
Add 'is' prefix to boolean getters if their meaning is ambiguous
...
- plus minor code cleanup
- ID -> Id or id
2012-06-12 17:58:22 +09:00
Trustin Lee
ecd0ae5406
Prefer MessageBuf over Queue where possible
...
- Also replaced thread safe queues with non-thread-safe ones where
possible
- Unpooled.wrappedBuffer(Queue<T>) does not wrap MessageBuf anymore
2012-06-12 17:02:00 +09:00
Trustin Lee
e1faea035e
Automatic clean-up with Eclipse
...
- Mostly import organization & whitespace removal
2012-06-11 23:04:04 +09:00
Trustin Lee
6211e53e86
Code clean-up based on IntelliJ code analysis
2012-06-11 22:54:28 +09:00
Trustin Lee
754392aaa9
Add ByteBuf.order(ByteOrder) method to simplify little endian access
...
- Removed all methods that requires ByteOrder as a parameter
from Unpooled (formerly ByteBufs/ChannelBuffers)
- Instead, a user calls order(ByteOrder) to get a little endian
version of the user's buffer
- This gives less overwhelming number of methods in Unpooled.
2012-06-11 20:24:44 +09:00
Trustin Lee
876847fd20
Merge MessageBufs and ByteBufs into Unpooled
...
- e.g. Unpooled.messageBuffer()
- It will make much more sense once we introduce pooling:
- i.e. Pooled.buffer()
2012-06-11 17:02:29 +09:00
Trustin Lee
7d36f936c8
Fix failing tests
2012-06-11 11:35:07 +09:00
Trustin Lee
574d84e98e
Remove ChannelBufferHolder / Add more handler interfaces for type safety
...
- ChannelInboundHandler and ChannelOutboundHandler does not have a type
parameter anymore.
- User should implement ChannelInboundMessageHandler or
ChannelOutboundMessageHandler.
2012-06-10 12:22:32 +09:00
Trustin Lee
a849d11877
ChannelBuffers -> ByteBufs / Add MessageBuf & ChannelBuf
...
- Add MessageBuf which replaces java.util.Queue
- Add ChannelBuf which is common type of ByteBuf and ChannelBuf
- ChannelBuffers was renamed to ByteBufs
- Add MessageBufs
- All these changes are going to replace ChannelBufferHolder.
2012-06-10 11:31:39 +09:00
Trustin Lee
5164d91255
Rename ChannelBuffer to ByteBuf as discussed before
...
- ChannelBuffer gives a perception that it's a buffer of a
channel, but channel's buffer is now a byte buffer or a message
buffer. Therefore letting it be as is is going to be confusing.
2012-06-10 11:08:43 +09:00
Trustin Lee
e376888d48
Replace 'Stream' with 'Byte'
...
- In computing, 'stream' means both byte stream and message stream,
which is confusing.
- Also, we were already mixing stream and byte in some places and
it's better use the terms consistently.
(e.g. inboundByteBuffer & inbound stream)
2012-06-09 21:05:59 +09:00
Trustin Lee
468a3228a4
Fit every line into 120 columns
2012-06-08 19:28:12 +09:00
Trustin Lee
748de5ea83
Fix a compilation error
2012-06-08 10:02:44 +09:00
Trustin Lee
92cbe6f980
Support long Expires dates and commas in cookie values ( #96 )
...
- Contribution by @valodzka
2012-06-08 09:25:39 +09:00
Trustin Lee
4a23c2a6eb
Fix checkstyle errors
2012-06-07 22:01:59 +09:00
Trustin Lee
10f7a31908
Fixed SpdySessionHandlerTest / Fixed NPE in EmbeddedChannel
...
- Some tests like SpdySessionHandlerTest accesses outbound buffer
even before the outbound buffer is initialized by
AbstractEmbeddedChannel's subclasses, leading to NPE at <init>.
To fix this problem, subclasses now pass the outbound buffer as
a constructor parameter to AbstractEmbeddedChannel.
2012-06-07 21:33:31 +09:00
Trustin Lee
994038975a
Port HttpContentEncoder/Decoder to use EmbeddedStreamChannel / Cleanup
...
- Removed unused constructor parameter in AbstractChannel
- Re-enabled GZIP encoding in HTTP snoop example
2012-06-07 21:06:56 +09:00
Trustin Lee
8701e24b9a
Add back Channel(Inbound|Outbound)(Message|Stream)HandlerAdapter
...
- they are useful when creating an anonymous class
- Also added back CombinedChannelHandler with extra constraints
2012-06-07 17:49:45 +09:00
Trustin Lee
ea0c9cfe79
Post-overhaul fixes / Split LoggingHandler into three
...
- LoggingHandler now only logs state and operations
- StreamLoggingHandler and MessageLoggingHandler log the buffer content
- Added ChannelOperationHandlerAdapter
- Used by WriteTimeoutHandler
2012-06-07 16:56:21 +09:00
Trustin Lee
5e93d206ff
Overhaul - Split ChannelHandler & Merge ChannelHandlerContext
...
- Extracted some handler methods from ChannelInboundHandler into
ChannelStateHandler
- Extracted some handler methods from ChannelOutboundHandler into
ChannelOperationHandler
- Moved exceptionCaught and userEventTriggered are now in
ChannelHandler
- Channel(Inbound|Outbound)HandlerContext is merged into
ChannelHandlerContext
- ChannelHandlerContext adds direct access methods for inboud and
outbound buffers
- The use of ChannelBufferHolder is minimal now.
- Before: inbound().byteBuffer()
- After: inboundByteBuffer()
- Simpler and better performance
- Bypass buffer types were removed because it just does not work at all
with the thread model.
- All handlers that uses a bypass buffer are broken. Will fix soon.
- CombinedHandlerAdapter does not make sense anymore either because
there are four handler interfaces to consider and often the two
handlers will implement the same handler interface such as
ChannelStateHandler. Thinking of better ways to provide this feature
2012-06-07 14:52:33 +09:00
Trustin Lee
3def2e6598
Fix more checkstyle errors
2012-06-07 09:19:14 +09:00
Frédéric Brégier
c2e3d305b4
Merge pull request #381 from fredericBregier/master
...
Improve HTTP message streaming in decoder same as #380
2012-06-05 10:05:34 -07:00
Frédéric Brégier
06e754eb81
Improve HTTP message streaming in decoder, in Master same as #380 submitted fix
2012-06-05 19:56:01 +03:00
Trustin Lee
1eced1e9e3
Update license headers
2012-06-04 13:31:44 -07:00