Norman Maurer
1e515b092c
fixing type on event/send argument
2012-11-27 19:37:28 +01:00
Trustin Lee
e7fd2afc25
Remove redundant exception message
2012-11-26 15:33:57 +09:00
Trustin Lee
0a1c5bef21
Make CompatibleMarshallingDecoder discard the inbound buffer once TooLongFrameException is raised
...
(See #768 )
Once too long object is received, CompatibleMarshallingDecoder has to
discard all input from now on, just like MarshallingDecoder does.
Otherwise, the decoder will raise more exceptions because the decoder
has no idea anymore where the object starts.
Before this fix, SerialThreadLocalCompatibleMarshallingDecoderTest
logged many additional exceptions raised by the decoder after test is
finished.
2012-11-26 14:44:03 +09:00
Norman Maurer
ef481bfedb
[ #766 ] Rename method to extractFrame(..), no need to make it more complicated in 3
2012-11-25 17:53:56 +01:00
Norman Maurer
bc1ef572b9
[ #766 ] Add extract(..) method to FrameDecoder to allow easier optimizations in sub-classes and still make it consistent
2012-11-25 17:33:38 +01:00
Daniel Bevenius
ed65dffddf
Adding WebSocket Example using WebSocketServerProtocolHandler.
2012-11-25 14:28:52 +01:00
Benoit Sigoure
d4155ad518
Add a line-based frame decoder with good performance.
...
Using DelimiterBasedFrameDecoder with Delimiters.lineDelimiter() has
quadratic performance in the size of the input buffer. Needless to
say, the performance degrades pretty quickly as the size of the buffer
increases. Larger MTUs or loopback connections can make it so bad that
it appears that the code is "busy waiting", when in fact it's spending
almost 100% of the CPU time in DelimiterBasedFrameDecoder.indexOf().
Add a new LineBasedFrameDecoder that decodes line-delimited frames
in O(n) instead of DelimiterBasedFrameDecoder's O(n^2) implementation.
In OpenTSDB's telnet-style protocol decoder this resulted in throughput
increases of an order of magnitude.
Change DelimiterBasedFrameDecoder to automatically detect when the
frames are delimited by line endings, and automatically switch to
using LineBasedFrameDecoder under the hood. This means that all Netty
applications out there that using the combo DelimiterBasedFrameDecoder
with Delimiters.lineDelimiter() will automatically benefit from the
better performance of LineBasedFrameDecoder, without requiring a code
change.
2012-11-24 20:51:45 +01:00
Norman Maurer
26943f189c
[761] Fix possible NPE in cleanupWriteBuffer() when closing Channel
2012-11-23 06:47:10 +01:00
Jaen Saul
0cb145ed68
SPDY: fix header block values truncation in decompression
2012-11-20 20:25:37 +02:00
Norman Maurer
5ec179c33c
[ #723 ] Use ExecutorServer.shutdown() in ExecutorHandler when terminate it. This way not tasks are lost
2012-11-17 19:47:06 +01:00
Jeff Pinner
8e3ec00e33
SPDY: fixed session status (internal error misdocumented)
2012-11-17 19:27:07 +01:00
Norman Maurer
3e7c8341a6
[ #734 ] Make sure that ChannelFuture is also notified when write an unsupported message to the channel and also prevent a NPE which could be raised because of the bug before
2012-11-16 22:42:52 +01:00
Norman Maurer
d15f9eda08
[ #740 ] Fix WebSocketClientHandshaker00.finishHandshake() validations
2012-11-15 13:00:44 +01:00
Norman Maurer
1e8ed50482
[ #737 ] WebSocketClientHandshaker00 should set Content-Length header do workaround problem with proxy
2012-11-14 10:12:42 +01:00
Norman Maurer
50e171273d
[ #735 ] Improve the notification of the handshake future
2012-11-13 18:42:12 +01:00
Norman Maurer
966565d4b9
[ #735 ] Make sure the handshake ChannelFuture is notified after the right encoder is present in the ChannelPipeline
2012-11-13 09:31:34 +01:00
Norman Maurer
a0e9921517
[ #735 ] Make sure the handshake ChannelFuture is notified after the right encoder is present in the ChannelPipeline
2012-11-13 09:14:16 +01:00
Norman Maurer
df575c6cd0
[ #729 ] Correctly handle urls with empty abs_path in it when issue the websocket handshake
2012-11-12 15:33:23 +01:00
Trustin Lee
adee1b4156
Fix visibility warnings from the inspector.
2012-11-12 14:03:43 +09:00
Trustin Lee
262919b045
Allow '_' in parameter names although discouraged
2012-11-12 13:39:24 +09:00
Trustin Lee
c09f8c147d
Fix more inspection warnings + compilation errors
2012-11-12 13:24:59 +09:00
Trustin Lee
bcc088b3d7
Fix parameter namings + some more
2012-11-12 12:59:37 +09:00
Trustin Lee
369574078b
Fix inspection warnings related with JUnit usage
2012-11-12 12:45:06 +09:00
Trustin Lee
669fa64829
Fix various Javadoc issues / Do not use argN parameter names
2012-11-12 12:26:18 +09:00
Trustin Lee
d92236a124
Prefer {@code ...} to <code>...</code> / Fix deprecation warnings
2012-11-12 11:51:23 +09:00
Trustin Lee
c1b31f982e
Fix deprecation warnings
2012-11-12 11:25:58 +09:00
Trustin Lee
a3acde0b73
'break' statement in a 'finally' block!?
2012-11-12 09:55:07 +09:00
Trustin Lee
849a265c2e
Optimize imports
2012-11-12 09:47:20 +09:00
Trustin Lee
2fe3e495c1
Make a member field final wherever possible
2012-11-12 09:43:54 +09:00
Trustin Lee
d23766fa27
Replace a variable with a constant wherever possible
2012-11-12 09:43:14 +09:00
Trustin Lee
12115198d0
Remove redundant 'else' branches.
2012-11-12 09:31:40 +09:00
Trustin Lee
4cd7fb1abb
Remove unnecessary 'return's / Clean up QueryStringDecoder
2012-11-12 09:15:33 +09:00
Trustin Lee
a76cdc26d0
Remove unnecessary qualifiers
2012-11-12 09:11:48 +09:00
Trustin Lee
dc8d9fac87
Prefer "str".equals(var) to var.equals("str") / Add proper null checks
2012-11-12 09:00:59 +09:00
Norman Maurer
95074e3677
Allow to serve more then one bound port per Thread. This fix the problem that you was not able to bound thousends of ports without huge amount of threads.
2012-11-11 18:52:28 +01:00
Trustin Lee
6be84510dc
More robust localhost resolution
...
Ensure the resolved localhost can be bound and connected actually
2012-11-10 08:45:07 +09:00
Trustin Lee
922a8dbb47
Use 'x' over "x" wherever possible / String.equals("") -> isEmpty()
2012-11-10 08:03:52 +09:00
Trustin Lee
d638052036
Add 'static' modifier to the methods that don't need to be member methods
2012-11-10 07:54:33 +09:00
Trustin Lee
ffe5459a88
Replace keySet() + unnecessary map lookup with entrySet()
2012-11-10 07:36:42 +09:00
Trustin Lee
9a87f1748c
Make classes static wherever possible
2012-11-10 07:32:52 +09:00
Trustin Lee
9a4296f320
Use foreach loop wherever possible / Prefer String.contains() to indexOf() >= 0 / Prefer StringUtil.split() to String.split()
2012-11-10 07:24:54 +09:00
Trustin Lee
ab02e90684
Remove methods overridden but identical with the super implementation / Make constructors of abstract classes protected rather than non-sense public
...
AbstractWrappedByteBuf.capacity(int) should raise a UnsupportedOperationException rather than ReadOnlyBufferException.
2012-11-10 07:10:30 +09:00
Trustin Lee
ac53b9e99e
Remove unnecessary throws clauses for unchecked exceptions
2012-11-10 07:07:37 +09:00
Trustin Lee
4b4c6a436b
Remove unused imports
2012-11-10 07:05:18 +09:00
Trustin Lee
bc7eb20c6e
Remove various unnecesary qualifiers
2012-11-10 07:02:56 +09:00
Trustin Lee
44159abefa
Remove redundant field initialization
2012-11-10 06:56:39 +09:00
Trustin Lee
1b35cfee85
Remove redundant throws clauses / Suppress inspections for some false positives
2012-11-10 06:47:58 +09:00
Trustin Lee
c3c75717db
Remove unnecessary this, parenthesis, and semicolons
2012-11-10 02:26:59 +09:00
Trustin Lee
5d1690dfa7
Add missing final modifiers
2012-11-10 02:19:39 +09:00
Trustin Lee
6453b71ab0
Remove recundant type casting
2012-11-10 02:13:33 +09:00
Trustin Lee
f4585b9f53
Remove unnecessary null check before equals()
2012-11-10 01:34:39 +09:00
Trustin Lee
ff03df6851
Remove unnecessary 'final' on parameter
2012-11-10 01:33:16 +09:00
Trustin Lee
72d85f58eb
Remove unnecessarily qualified statis access
2012-11-10 01:31:31 +09:00
Trustin Lee
53cecdb31b
Prefer isEmpty() over size() == 0
2012-11-10 01:21:25 +09:00
Trustin Lee
0bc6ace8d1
Remove redundant no-arg constructors
2012-11-10 01:08:32 +09:00
Trustin Lee
74a235d29f
Simplify array initialization
2012-11-10 01:00:26 +09:00
Trustin Lee
d8f0bc9e3e
Do not use Vector
2012-11-10 00:59:10 +09:00
Trustin Lee
59bc375f73
Fix backward incompatibility
2012-11-10 00:48:35 +09:00
Trustin Lee
c34d0a2272
Replace dynamic regular expressions with precompiled Patterns or new StringUtil.split()
2012-11-10 00:42:35 +09:00
Trustin Lee
00d9111833
Remove concatenation with empty string
2012-11-09 17:55:12 +09:00
Trustin Lee
b0b765001c
Enum should not have a non-final value
2012-11-09 17:37:03 +09:00
Trustin Lee
c06722c232
Add missing @Override annotation
2012-11-09 17:34:24 +09:00
Trustin Lee
bdaa4fbfeb
Simplify SingletonHolder by using interface instead of static class
2012-11-09 17:33:26 +09:00
Trustin Lee
779ddd1d2f
Replace a = a + b to a += b
2012-11-09 17:19:30 +09:00
Trustin Lee
b1f2fe752b
Move private methods only used from inner classes to the inner classes
2012-11-09 17:19:10 +09:00
Trustin Lee
3e21e3250f
Fix overly-strong type casts
2012-11-09 17:15:13 +09:00
Norman Maurer
1a006fafad
[ #719 ] Handle http requests without an absolute path the right way when encoding them, which is adding / to it
2012-11-09 07:16:32 +01:00
Norman Maurer
55457691d2
[ #712 ] Fix parsing dates in the past bug in CookieDecoder
2012-11-08 10:02:50 +01:00
Norman Maurer
88c2200264
Fix checkstyle
2012-11-02 20:20:19 +01:00
Norman Maurer
19104e8774
[ #698 ] ExceptionEvent could be swallowed if last handler in pipeline is a ChannelDownstreamHandler
2012-11-02 20:15:17 +01:00
Jeff Pinner
b0db3a04aa
HTTP method should be case sensitive (RFC-2616 Sec. 5.1.1)
2012-11-01 22:42:12 -07:00
Norman Maurer
d9090ecb1b
Merge branch '3' of https://github.com/netty/netty into 3
2012-10-30 08:49:11 +01:00
Norman Maurer
fd61b27ee8
[ #691 ] Correctly handle SpdyRstStreamFrame
2012-10-30 08:19:48 +01:00
Norman Maurer
62395ad1c5
Merge pull request #693 from veebs/3ws
...
updated autobahn test instructions in 3 branch
2012-10-29 23:21:30 -07:00
Norman Maurer
db697f1f06
[694] WebSocket08FrameDecoder calls await*() in the Worker-Thread
2012-10-29 21:04:11 +01:00
Veebs
43d937b39f
updated autobahn test instructions
2012-10-29 04:11:02 -07:00
Norman Maurer
b1cfaad9bf
Fix NPE which can accour when the Selector is closed but there are still timeout tasks to handle on client mode. The NPE does not have any bad side-effects, but its still ugly. See #685
2012-10-26 11:40:20 +02:00
Trustin Lee
b9429c930f
[ #679 ] Netty 3.5.8 breaks app on startup with NPE
...
- Get system property when requested; do not cache it.
2012-10-24 10:38:23 -07:00
Norman Maurer
99698a5272
Fix NPE when System property os.name does not exist. See #669 and #679
2012-10-24 18:46:56 +02:00
Norman Maurer
e3cf41c9fb
Upgrade to apiviz 1.3.2.GA. See #676
2012-10-23 13:20:02 +02:00
Norman Maurer
1e8b7d896a
Fix comment
2012-10-17 15:47:21 +02:00
Norman Maurer
9c921b050f
Some more optimization in HashedWheelTimer based on the comments of @viktorklang
2012-10-17 15:26:54 +02:00
Trustin Lee
543cb17acd
Reduce synchronization overhead in HashedWheelTimer.start/stop()
2012-10-16 13:38:25 -07:00
Norman Maurer
b75ab6171c
Only parse the packet length once per encrypted packet. See #658
2012-10-16 14:21:42 +02:00
Norman Maurer
52d64afa2f
Fix the detection of encrypted data. See #655
2012-10-16 13:23:18 +02:00
Norman Maurer
0c82f5d2e5
Introduce helper method to detect if a buffer is encrypted. See #657
2012-10-16 13:22:41 +02:00
Norman Maurer
f5969778d0
Explicit close streams
2012-10-16 11:26:04 +02:00
Ngoc Dao
fb5e199d9e
Uncomment the following lines if you want HTTPS
2012-10-09 14:33:12 +09:00
Ngoc Dao
ae909f5d12
Uncomment the following line if you want HTTPS: add missing imports
2012-10-09 14:30:15 +09:00
Norman Maurer
2056882cfc
Fire the IdleStateEvent and also the ReadTimeOutException / WriteTimeOutException from the Worker-Thread. See #641
2012-10-05 20:08:21 +02:00
Norman Maurer
8669732479
Fix checkstyle
2012-10-05 07:16:54 +02:00
Norman Maurer
4bca91786a
Merge pull request #637 from losipiuk/3
...
Call ChunkedWriteHandler.flush() once again if tried when locked.
2012-10-04 02:54:31 -07:00
Norman Maurer
389cdb124f
Add a test that I wrote while working on some OOME problem
2012-10-04 11:07:05 +02:00
Norman Maurer
a6e89aa142
Manually GC direct ByteBuffer that is used by the Worker's on releaseExternalResources() to free up memory asap. See #638
2012-10-04 09:02:53 +02:00
Lukasz Osipiuk
20509fb516
Call ChunkedWriteHandler.flush() once again if tried when locked.
...
Force recursive call of ChunkedWriteHandler.flush() if another thread
tried to call it when lock was held.
Solves problem of lost resumeTransfer() call.
2012-10-02 15:17:23 +02:00
Norman Maurer
6ca523a754
Merge pull request #631 from ngocdaothanh/3
...
Add CORS headers
2012-10-01 21:48:37 -07:00
Norman Maurer
4dc4664692
Fix year in header
2012-10-01 06:59:13 +02:00
Norman Maurer
8f4c583e40
Fix NPE in MemoryAwareThreadPoolExecutor and also add a testcase. See #634
2012-10-01 06:57:12 +02:00
Ngoc Dao
605bbac15c
Sort header names
2012-09-28 19:25:27 +09:00
Ngoc Dao
8c694b3bfb
Add CORS headers
...
http://en.wikipedia.org/wiki/Cross-origin_resource_sharing
https://developer.mozilla.org/en-US/docs/HTTP_access_control
2012-09-28 17:10:54 +09:00