andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
10,196 Commits 27 Branches 234 Tags 84 MiB
Java 99.8%
Shell 0.1%
50a83ec8a8
Go to file
Norman Maurer 50a83ec8a8 DefaultThreadFactory must not use Thread.currentThread() when constructed without ThreadGroup (#11119) 
Motivation:

We had a bug in out DefaulThreadFactory as it always retrieved the ThreadGroup to used during creation time when now explicit ThreadGroup was given. This is problematic as the Thread may die and so the ThreadGroup is destroyed even tho the DefaultThreadFactory is still used.

This could produce exceptions like:

java.lang.IllegalThreadStateException
        at java.lang.ThreadGroup.addUnstarted(ThreadGroup.java:867)
        at java.lang.Thread.init(Thread.java:405)
        at java.lang.Thread.init(Thread.java:349)
        at java.lang.Thread.<init>(Thread.java:599)
        at io.netty.util.concurrent.FastThreadLocalThread.<init>(FastThreadLocalThread.java:60)
        at io.netty.util.concurrent.DefaultThreadFactory.newThread(DefaultThreadFactory.java:122)
        at io.netty.util.concurrent.DefaultThreadFactory.newThread(DefaultThreadFactory.java:106)
        at io.netty.util.concurrent.ThreadPerTaskExecutor.execute(ThreadPerTaskExecutor.java:32)
        at io.netty.util.internal.ThreadExecutorMap$1.execute(ThreadExecutorMap.java:57)
        at io.netty.util.concurrent.SingleThreadEventExecutor.doStartThread(SingleThreadEventExecutor.java:978)
        at io.netty.util.concurrent.SingleThreadEventExecutor.startThread(SingleThreadEventExecutor.java:947)
        at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:830)
        at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:818)
        at io.netty.channel.AbstractChannel$AbstractUnsafe.register(AbstractChannel.java:471)
        at io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:87)
        at io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:81)
        at io.netty.channel.MultithreadEventLoopGroup.register(MultithreadEventLoopGroup.java:86)
        at io.netty.bootstrap.AbstractBootstrap.initAndRegister(AbstractBootstrap.java:323)
        at io.netty.bootstrap.AbstractBootstrap.doBind(AbstractBootstrap.java:272)
        at io.netty.bootstrap.AbstractBootstrap.bind(AbstractBootstrap.java:239)
        at io.netty.incubator.codec.quic.QuicTestUtils.newServer(QuicTestUtils.java:138)
        at io.netty.incubator.codec.quic.QuicTestUtils.newServer(QuicTestUtils.java:143)
        at io.netty.incubator.codec.quic.QuicTestUtils.newServer(QuicTestUtils.java:147)
        at io.netty.incubator.codec.quic.QuicStreamFrameTest.testCloseHalfClosure(QuicStreamFrameTest.java:48)
        at io.netty.incubator.codec.quic.QuicStreamFrameTest.testCloseHalfClosureUnidirectional(QuicStreamFrameTest.java:35)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
        at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.lang.Thread.run(Thread.java:748)

Modifications:

- If the user dont specify a ThreadGroup we will just pass null to the constructor of FastThreadLocalThread and so let it retrieve on creation time
- Adjust tests

Result:

Don't risk to see IllegalThreadStateExceptions.
2021-03-26 18:46:55 +01:00
.github Github Actions dawidd6/action-download-artifact set workflow_conclusion (#11096) 2021-03-17 12:20:03 -07:00
.mvn Use latest maven release (#9820) 2019-11-27 14:45:48 +01:00
all Update dependency declaration in all pom.xml (#10967) 2021-01-27 10:25:36 +01:00
bom Fix classifier usage in bom 2020-12-08 14:56:38 +01:00
buffer Fix alignment handling for pooled direct buffers (#11106) 2021-03-23 17:09:44 +01:00
codec Add support for direct ByteBufs in JdkZlibEncoder and JdkZlibDecoder (#11057) 2021-03-05 13:29:20 +01:00
codec-dns Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
codec-haproxy Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
codec-http Fix exception if Response has content (#11093) 2021-03-21 14:50:05 +01:00
codec-http2 Allow to have an empty path when convert a CONNECT request (#11108) 2021-03-24 10:52:08 +01:00
codec-memcache Introduce ByteBufConvertible interface (#11036) 2021-02-26 15:03:58 +01:00
codec-mqtt Simplity some code (#11000) 2021-02-11 09:06:16 +01:00
codec-redis Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
codec-smtp Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
codec-socks Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
codec-stomp Provide ability to extend StompSubframeEncoder and improve full stomp frame encoding (allocate one buffer for full frame considering the size of the headers) (#10778) 2020-12-07 09:59:17 +01:00
codec-xml Simplity some code (#11000) 2021-02-11 09:06:16 +01:00
common DefaultThreadFactory must not use Thread.currentThread() when constructed without ThreadGroup (#11119) 2021-03-26 18:46:55 +01:00
dev-tools Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
docker Let's use gcc10 when cross-compiling for LSE support (#11112) 2021-03-25 09:34:08 +01:00
example Remove unnecessary this. (#11035) 2021-02-26 12:13:59 +01:00
handler Don't bind to a specify port during SSLEngine tests as the port may also be used (#11102) 2021-03-20 12:46:08 +01:00
handler-proxy Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
license Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
microbench Minimize get byte multipart and fix buffer reuse (#11001) 2021-02-26 14:26:24 +01:00
resolver Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
resolver-dns Fix compile error introduced by 06739ed890 2021-03-08 12:17:34 +01:00
resolver-dns-native-macos Use netty-jni-util 0.0.3.Final 2021-03-25 11:40:40 +01:00
scripts Bring forward build automation changes (#11052) 2021-03-02 17:44:03 +01:00
tarball Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
testsuite SslHandler flushing with TCP Fast Open fix (#11077) 2021-03-14 14:27:10 +01:00
testsuite-autobahn Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
testsuite-http2 Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
testsuite-native Verify we can load native modules and add job that verifies on aarch64 as well (#10933) 2021-01-14 17:15:29 +01:00
testsuite-native-image Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
testsuite-native-image-client Fix native image build for the cases when io.netty.util.NetUtil is initialized at run-time (#10799) 2020-12-07 18:22:03 +01:00
testsuite-native-image-client-runtime-init Fix native image build for the cases when io.netty.util.NetUtil is initialized at run-time (#10799) 2020-12-07 18:22:03 +01:00
testsuite-osgi Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
testsuite-shading Always include the OS in the tcnative library name (#11064) 2021-03-08 19:27:06 +01:00
transport Continue reading when the number of bytes is less then the configured… (#11089) 2021-03-17 13:18:39 +01:00
transport-blockhound-tests Allow blocking calls when parsing etcResolver/hosts files (#11009) 2021-02-11 11:05:14 +01:00
transport-native-epoll Use netty-jni-util 0.0.3.Final 2021-03-25 11:40:40 +01:00
transport-native-kqueue Use netty-jni-util 0.0.3.Final 2021-03-25 11:40:40 +01:00
transport-native-unix-common Fix build for aarch64 (#11116) 2021-03-25 12:07:15 +01:00
transport-native-unix-common-tests Use Files.createTempFile(...) to ensure the file is created with proper permissions 2021-02-08 18:17:31 +01:00
transport-sctp Use http in xmlns URIs to make maven release plugin happy again (#10788) 2020-11-10 10:51:05 +01:00
transport-udt/lib/bin/lib/x86_64-MacOSX-gpp/jni Replace reflection usage with MethodHandles when performance matters (#10097) 2020-03-11 21:04:40 +01:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitattributes Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
.gitignore Ignore .shelf/ folder generated by IntelliJ IDEA (#10445) 2020-08-03 07:52:18 +02:00
.lgtm.yml Enables lgtm.com to process this project and create a CodeQL database 2020-01-20 19:22:49 +01:00
CONTRIBUTING.md Change the netty.io homepage scheme(http -> https) (#9344) 2019-07-09 21:10:14 +02:00
LICENSE.txt Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
mvnw Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
mvnw.cmd Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
nohttp-checkstyle-suppressions.xml Ensure Checkstyle suppression for dependency-reduced-pom.xml on Windows (#10899) 2021-01-01 19:31:01 +01:00
nohttp-checkstyle.xml Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
NOTICE.txt Fix License type of dnsinfo (#10773) 2020-11-04 10:41:41 +01:00
pom.xml Use netty-jni-util 0.0.3.Final 2021-03-25 11:40:40 +01:00
README.md Fix url in README.md (#10915) 2021-01-11 07:50:43 +01:00
run-example.sh Add DNS client examples for run-example.sh (#10283) 2020-05-14 12:10:48 +02:00
SECURITY.md Added a security policy (#10692) 2020-10-15 20:40:05 +02:00

README.md

Build project

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

Links

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+ / 4.1+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.1 resides in the branch '3.9' and the branch '4.1' respectively.

Usage with JDK 9+

Netty can be used in modular JDK9+ applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.all
  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.